GNUsocial
/
gnu-social
4
0
Fork 1
Code Issues Releases Wiki Activity

Use join instead of exists in SQL

This commit is contained in:
Mikael Nordfeldth 2016-03-29 14:36:27 +02:00
parent 4ea79bc396
commit 0177c8f1cf
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
scripts/upgrade.php
View File

@ -171,9 +171,14 @@ function initConversation()
printfnq("Ensuring all conversations have a row in conversation table...");
$notice = new Notice();
$notice->query('select distinct notice.conversation from notice '.
'where notice.conversation is not null '.
'and not exists (select conversation.id from conversation where id = notice.conversation)');
$notice->selectAdd();
$notice->selectAdd('DISTINCT conversation');
$notice->joinAdd(['conversation', 'conversation:id'], 'LEFT'); // LEFT to get the null values for conversation.id
$notice->whereAdd('conversation.id IS NULL');
if ($notice->find()) {
printfnq(" fixing {$notice->N} missing conversation entries...");
}
while ($notice->fetch()) {