GNUsocial/gnu-social
4
0
Fork 1
Code Issues Releases Wiki Activity

safer storage for diskcacheplugin

Browse Source
This commit is contained in:
Evan Prodromou 2010-01-11 16:23:34 -08:00
parent bd6571c2e1
commit 04c76fc4e5
1 changed files with 22 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
plugins/DiskCachePlugin.php
View File

@ -68,10 +68,13 @@ class DiskCachePlugin extends Plugin
function onStartCacheGet(&$key, &$value) function onStartCacheGet(&$key, &$value)
{ {
$filename = $this->keyToFilename($key); $filename = $this->keyToFilename($key);
if (file_exists($filename)) { if (file_exists($filename)) {
$data = file_get_contents($filename); $data = file_get_contents($filename);
if ($data !== false) {
$value = unserialize($data); $value = unserialize($data);
} }
}
Event::handle('EndCacheGet', array($key, &$value)); Event::handle('EndCacheGet', array($key, &$value));
return false; return false;
@ -116,7 +119,24 @@ class DiskCachePlugin extends Plugin
return false; return false;
} }
file_put_contents($filename, serialize($value)); // Write to a temp file and move to destination
$tempname = tempnam(null, 'statusnetdiskcache');
$result = file_put_contents($tempname, serialize($value));
if ($result === false) {
$this->log(LOG_ERR, "Couldn't write '$key' to temp file '$tempname'");
return false;
}
$result = rename($tempname, $filename);
if (!$result) {
$this->log(LOG_ERR, "Couldn't move temp file '$tempname' to path '$filename' for key '$key'");
@unlink($tempname);
return false;
}
Event::handle('EndCacheSet', array($key, $value, $flag, Event::handle('EndCacheSet', array($key, $value, $flag,
$expiry)); $expiry));