Make sure something's an int before comparing to -1

This commit is contained in:
Evan Prodromou 2011-04-09 15:34:33 -04:00
parent 285c2ee72d
commit 070b07632b
3 changed files with 3 additions and 3 deletions

View File

@ -100,7 +100,7 @@ class Notice extends Memcached_DataObject
function getProfile()
{
if ($this->_profile == -1) {
if (is_int($this->_profile) && $this->_profile == -1) {
$this->_profile = Profile::staticGet('id', $this->profile_id);
if (empty($this->_profile)) {

View File

@ -56,7 +56,7 @@ class Profile extends Memcached_DataObject
function getUser()
{
if ($this->_user == -1) {
if (is_int($this->_user) && $this->_user == -1) {
$this->_user = User::staticGet('id', $this->id);
}

View File

@ -80,7 +80,7 @@ class User extends Memcached_DataObject
*/
function getProfile()
{
if ($this->_profile == -1) { // invalid but distinct from null
if (is_int($this->_profile) && $this->_profile == -1) { // invalid but distinct from null
$this->_profile = Profile::staticGet('id', $this->id);
if (empty($this->_profile)) {
throw new UserNoProfileException($this);