GNUsocial/gnu-social
4
0
Fork 1
Code Issues Releases Wiki Activity

Add some data integrity checks on oembed tests (shows a bug on identi.ca test case -- missing width/height in photo data)

Browse Source
This commit is contained in:
Brion Vibber 2010-11-15 12:58:00 -08:00
parent 89d5993674
commit 0735ca86d2
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
tests/oEmbedTest.php
View File

@ -69,6 +69,18 @@ class oEmbedTest extends PHPUnit_Framework_TestCase
try { try {
$data = oEmbedHelper::getObject($url); $data = oEmbedHelper::getObject($url);
$this->assertEquals($expectedType, $data->type); $this->assertEquals($expectedType, $data->type);
if ($data->type == 'photo') {
$this->assertTrue(!empty($data->url), 'Photo must have a URL.');
$this->assertTrue(!empty($data->width), 'Photo must have a width.');
$this->assertTrue(!empty($data->height), 'Photo must have a height.');
} else if ($data->type == 'video') {
$this->assertTrue(!empty($data->html), 'Video must have embedding HTML.');
$this->assertTrue(!empty($data->thumbnail_url), 'Video should have a thumbnail.');
}
if (!empty($data->thumbnail_url)) {
$this->assertTrue(!empty($data->thumbnail_width), 'Thumbnail must list a width.');
$this->assertTrue(!empty($data->thumbnail_height), 'Thumbnail must list a height.');
}
} catch (Exception $e) { } catch (Exception $e) {
if ($expectedType == 'none') { if ($expectedType == 'none') {
$this->assertEquals($expectedType, 'none', 'Should not have data for this URL.'); $this->assertEquals($expectedType, 'none', 'Should not have data for this URL.');