Fave insert logging directly in insert()

This commit is contained in:
Mikael Nordfeldth 2015-02-03 14:58:22 +01:00
parent e41d324a53
commit 1104ea2a0e

View File

@ -63,12 +63,9 @@ class Fave extends Managed_DataObject
$notice, $notice,
$fave->created); $fave->created);
try { // throws exception (Fave specific until migrated into Managed_DataObject
$fave->insert(); $fave->insert();
} catch (ServerException $e) {
common_log_db_error($fave, 'INSERT', __FILE__);
throw $e;
}
self::blowCacheForProfileId($fave->user_id); self::blowCacheForProfileId($fave->user_id);
self::blowCacheForNoticeId($fave->notice_id); self::blowCacheForNoticeId($fave->notice_id);
self::blow('popular'); self::blow('popular');
@ -82,7 +79,8 @@ class Fave extends Managed_DataObject
// exception throwing takeover! // exception throwing takeover!
public function insert() public function insert()
{ {
if (!parent::insert()) { if (parent::insert()===false) {
common_log_db_error($this, 'INSERT', __FILE__);
throw new ServerException(sprintf(_m('Could not store new object of type %s'), get_called_class())); throw new ServerException(sprintf(_m('Could not store new object of type %s'), get_called_class()));
} }
self::blowCacheForProfileId($this->user_id); self::blowCacheForProfileId($this->user_id);