not correctly checking results of XML-RPC request

This commit is contained in:
Evan Prodromou 2009-03-22 15:34:09 -04:00
parent 2e3f228b4b
commit 149fa14bd4

View File

@ -50,7 +50,15 @@ function ping_broadcast_notice($notice) {
"User-Agent: Laconica/".LACONICA_VERSION."\r\n", "User-Agent: Laconica/".LACONICA_VERSION."\r\n",
'content' => $req))); 'content' => $req)));
$file = file_get_contents($notify_url, false, $context); $file = file_get_contents($notify_url, false, $context);
if ($file === false || mb_strlen($file) == 0) {
common_log(LOG_WARNING,
"XML-RPC empty results for ping ($notify_url, $notice->id) ");
continue;
}
$response = xmlrpc_decode($file); $response = xmlrpc_decode($file);
if (xmlrpc_is_fault($response)) { if (xmlrpc_is_fault($response)) {
common_log(LOG_WARNING, common_log(LOG_WARNING,
"XML-RPC error for ping ($notify_url, $notice->id) ". "XML-RPC error for ping ($notify_url, $notice->id) ".