From 1b69d028755ca91c6b26ec88b904391f57ce7305 Mon Sep 17 00:00:00 2001 From: Diogo Peralta Cordeiro Date: Fri, 16 Jul 2021 14:45:56 +0100 Subject: [PATCH] [MEDIA][MediaFile] Prevent issues with huge original filenames --- lib/media/mediafile.php | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/media/mediafile.php b/lib/media/mediafile.php index 4f573baba5..0a653fa6d3 100644 --- a/lib/media/mediafile.php +++ b/lib/media/mediafile.php @@ -326,7 +326,10 @@ class MediaFile $original_name = preg_replace('/\.+.+$/i', ".{$ext}", $original_name); } - $enc_name = bin2hex($original_name); + // Avoid unnecessarily large file names + $pretty_name = substr(trim($original_name), 0, 30); // 30 seems like a sensible limit for a file name + + $enc_name = bin2hex($pretty_name); return "{$enc_name}-{$filehash}"; }