From 1f2f57b03bbd598de941f08d31df8e2d5dab184e Mon Sep 17 00:00:00 2001
From: Alexei Sorokin <sor.alexei@meowr.ru>
Date: Fri, 13 Sep 2019 12:11:43 +0300
Subject: [PATCH] [CORE] Fix logging of very early failures

---
 lib/util/util.php | 7 +++++--
 public/index.php  | 1 +
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/lib/util/util.php b/lib/util/util.php
index 9f36292029..bf3b4e8001 100644
--- a/lib/util/util.php
+++ b/lib/util/util.php
@@ -1417,14 +1417,14 @@ function common_path($relative, $ssl=false, $addSession=true)
         } elseif (common_config('site', 'server')) {
             $serverpart = common_config('site', 'server');
         } else {
-            common_log(LOG_ERR, 'Site server not configured, unable to determine site name.');
+            throw new ServerException('Site server not configured, unable to determine site name.');
         }
     } else {
         $proto = 'http';
         if (common_config('site', 'server')) {
             $serverpart = common_config('site', 'server');
         } else {
-            common_log(LOG_ERR, 'Site server not configured, unable to determine site name.');
+            throw new ServerException('Site server not configured, unable to determine site name.');
         }
     }
 
@@ -2151,6 +2151,9 @@ function common_negotiate_type($cprefs, $sprefs)
 function common_config($main, $sub=null)
 {
     global $config;
+    if (is_null($config)) {
+        throw new ServerException('common_config was invoked before config.php was read');
+    }
     if (is_null($sub)) {
         // Return the config category array
         return array_key_exists($main, $config) ? $config[$main] : [];
diff --git a/public/index.php b/public/index.php
index 774796ca5a..59eac50755 100644
--- a/public/index.php
+++ b/public/index.php
@@ -156,6 +156,7 @@ function handleError($error)
     } catch (Exception $e) {
         // TRANS: Error message.
         echo _('An error occurred.');
+        error_log('Uncaught Exception: ' . $error);
         exit(-1);
     }
     exit(-1);