From ac6486f12e3a51fc0b7b1433de881934d8029299 Mon Sep 17 00:00:00 2001 From: Evan Prodromou Date: Thu, 12 Aug 2010 21:19:12 -0700 Subject: [PATCH 01/13] Plugin file and data file for notice title --- plugins/NoticeTitle/NoticeTitlePlugin.php | 111 +++++++++++++++++++++ plugins/NoticeTitle/Notice_title.php | 116 ++++++++++++++++++++++ 2 files changed, 227 insertions(+) create mode 100644 plugins/NoticeTitle/NoticeTitlePlugin.php create mode 100644 plugins/NoticeTitle/Notice_title.php diff --git a/plugins/NoticeTitle/NoticeTitlePlugin.php b/plugins/NoticeTitle/NoticeTitlePlugin.php new file mode 100644 index 0000000000..9dfb4b21c2 --- /dev/null +++ b/plugins/NoticeTitle/NoticeTitlePlugin.php @@ -0,0 +1,111 @@ +. + * + * @category NoticeTitle + * @package StatusNet + * @author Evan Prodromou + * @copyright 2010 StatusNet, Inc. + * @license http://www.fsf.org/licensing/licenses/agpl-3.0.html AGPL 3.0 + * @link http://status.net/ + */ + +if (!defined('STATUSNET')) { + // This check helps protect against security problems; + // your code file can't be executed directly from the web. + exit(1); +} + +define('NOTICE_TITLE_PLUGIN_VERSION', '0.1'); + +/** + * NoticeTitle plugin to add an optional title to notices. + * + * Stores notice titles in a secondary table, notice_title. + * + * @category NoticeTitle + * @package StatusNet + * @author Evan Prodromou + * @copyright 2010 StatusNet, Inc. + * @license http://www.fsf.org/licensing/licenses/agpl-3.0.html AGPL 3.0 + * @link http://status.net/ + */ + +class NoticeTitlePlugin extends Plugin +{ + /** + * Database schema setup + * + * Add the notice_title helper table + * + * @see Schema + * @see ColumnDef + * + * @return boolean hook value; true means continue processing, false means stop. + */ + + function onCheckSchema() + { + $schema = Schema::get(); + + // For storing titles for notices + + $schema->ensureTable('notice_title', + array(new ColumnDef('notice_id', 'integer', null, true, 'PRI'), + new ColumnDef('title', 'varchar', 255, false))); + + return true; + } + + /** + * Load related modules when needed + * + * @param string $cls Name of the class to be loaded + * + * @return boolean hook value; true means continue processing, false means stop. + */ + + function onAutoload($cls) + { + $dir = dirname(__FILE__); + + switch ($cls) + { + case 'Notice_title': + include_once $dir . '/'.$cls.'.php'; + return false; + default: + return true; + } + } + + function onPluginVersion(&$versions) + { + $versions[] = array('name' => 'NoticeTitle', + 'version' => NOTICE_TITLE_PLUGIN_VERSION, + 'author' => 'Evan Prodromou', + 'homepage' => 'http://status.net/wiki/Plugin:NoticeTitle', + 'rawdescription' => + _m('Adds optional titles to notices')); + return true; + } +} + diff --git a/plugins/NoticeTitle/Notice_title.php b/plugins/NoticeTitle/Notice_title.php new file mode 100644 index 0000000000..ed71f13567 --- /dev/null +++ b/plugins/NoticeTitle/Notice_title.php @@ -0,0 +1,116 @@ + + * @license http://www.fsf.org/licensing/licenses/agpl.html AGPLv3 + * @link http://status.net/ + * + * StatusNet - the distributed open-source microblogging tool + * Copyright (C) 2010, StatusNet, Inc. + * + * This program is free software: you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation, either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + */ + +if (!defined('STATUSNET')) { + exit(1); +} + +require_once INSTALLDIR . '/classes/Memcached_DataObject.php'; + +/** + * Data class for notice titles + * + * @category Action + * @package StatusNet + * @author Evan Prodromou + * @license http://www.fsf.org/licensing/licenses/agpl.html AGPLv3 + * @link http://status.net/ + * + * @see DB_DataObject + */ + +class Notice_title extends Memcached_DataObject +{ + public $__table = 'notice_title'; // table name + public $notice_id; // int(4) primary_key not_null + public $title; // varchar(255) + + /** + * Get an instance by key + * + * This is a utility method to get a single instance with a given key value. + * + * @param string $k Key to use to lookup (usually 'user_id' for this class) + * @param mixed $v Value to lookup + * + * @return Notice_title object found, or null for no hits + * + */ + + function staticGet($k, $v=null) + { + return Memcached_DataObject::staticGet('Notice_title', $k, $v); + } + + /** + * return table definition for DB_DataObject + * + * DB_DataObject needs to know something about the table to manipulate + * instances. This method provides all the DB_DataObject needs to know. + * + * @return array array of column definitions + */ + + function table() + { + return array('notice_id' => DB_DATAOBJECT_INT + DB_DATAOBJECT_NOTNULL, + 'title' => DB_DATAOBJECT_STR); + } + + /** + * return key definitions for DB_DataObject + * + * @return array list of key field names + */ + + function keys() + { + return array_keys($this->keyTypes()); + } + + /** + * return key definitions for Memcached_DataObject + */ + + function keyTypes() + { + return array('notice_id' => 'K'); + } + + /** + * Magic formula for non-autoincrementing integer primary keys + * + * @return array magic three-false array that stops auto-incrementing. + */ + + function sequenceKey() + { + return array(false, false, false); + } +} From 79b5f1cea5ffadf18d3680ddeb1f8bd4d974b059 Mon Sep 17 00:00:00 2001 From: Evan Prodromou Date: Thu, 12 Aug 2010 22:11:26 -0700 Subject: [PATCH 02/13] add title element to notice form --- plugins/NoticeTitle/NoticeTitlePlugin.php | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/plugins/NoticeTitle/NoticeTitlePlugin.php b/plugins/NoticeTitle/NoticeTitlePlugin.php index 9dfb4b21c2..524faef3a2 100644 --- a/plugins/NoticeTitle/NoticeTitlePlugin.php +++ b/plugins/NoticeTitle/NoticeTitlePlugin.php @@ -107,5 +107,18 @@ class NoticeTitlePlugin extends Plugin _m('Adds optional titles to notices')); return true; } + + function onStartShowNoticeFormData($form) + { + $form->out->element('input', array('type' => 'text', + 'id' => 'notice_title', + 'name' => 'notice_title', + 'size' => 40, + 'value' => _m('Title'), + 'style' => 'color: 333333', + 'onFocus' => 'this.value = ""; this.style = \'color: black\';')); + return true; + } + } From 7dd46222a86a54be9d268a36291b795087fbd5c8 Mon Sep 17 00:00:00 2001 From: Evan Prodromou Date: Fri, 13 Aug 2010 11:21:07 -0700 Subject: [PATCH 03/13] add StartNoticeSaveWeb and EndNoticeSaveWeb to hook web-based UI for notices --- EVENTS.txt | 11 +++++++++++ actions/newnotice.php | 14 +++++++++++--- 2 files changed, 22 insertions(+), 3 deletions(-) diff --git a/EVENTS.txt b/EVENTS.txt index 7784e7d42e..f34fcc3da0 100644 --- a/EVENTS.txt +++ b/EVENTS.txt @@ -1045,3 +1045,14 @@ StartActivityEnd: before the closing in a notice activity entry (last c EndActivityEnd: after the closing in a notice activity entry - &$notice: notice being output - &$xs: XMLStringer for output + +StartNoticeSaveWeb: before saving a notice through the Web interface +- $action: action being executed (instance of NewNoticeAction) +- &$authorId: integer ID of the author +- &$text: text of the notice +- &$options: additional options (location, replies, etc.) + +EndNoticeSaveWeb: after saving a notice through the Web interface +- $action: action being executed (instance of NewNoticeAction) +- $notice: notice that was saved + diff --git a/actions/newnotice.php b/actions/newnotice.php index 748d104ff9..ca6355cbff 100644 --- a/actions/newnotice.php +++ b/actions/newnotice.php @@ -203,10 +203,18 @@ class NewnoticeAction extends Action $options = array_merge($options, $locOptions); } - $notice = Notice::saveNew($user->id, $content_shortened, 'web', $options); + $author_id = $user->id; + $text = $content_shortened; - if (isset($upload)) { - $upload->attachToNotice($notice); + if (Event::handle('StartNoticeSaveWeb', array($this, &$author_id, &$text, &$options))) { + + $notice = Notice::saveNew($user->id, $content_shortened, 'web', $options); + + if (isset($upload)) { + $upload->attachToNotice($notice); + } + + Event::handle('EndNoticeSaveWeb', array($this, $notice)); } if ($this->boolean('ajax')) { From e2128b201952131ab78344b089b72a0b74521c86 Mon Sep 17 00:00:00 2001 From: Evan Prodromou Date: Fri, 13 Aug 2010 11:29:18 -0700 Subject: [PATCH 04/13] save the notice title when the notice is saved --- plugins/NoticeTitle/NoticeTitlePlugin.php | 33 ++++++++++++++++++++++- plugins/NoticeTitle/Notice_title.php | 2 ++ 2 files changed, 34 insertions(+), 1 deletion(-) diff --git a/plugins/NoticeTitle/NoticeTitlePlugin.php b/plugins/NoticeTitle/NoticeTitlePlugin.php index 524faef3a2..86a74a4da5 100644 --- a/plugins/NoticeTitle/NoticeTitlePlugin.php +++ b/plugins/NoticeTitle/NoticeTitlePlugin.php @@ -70,7 +70,7 @@ class NoticeTitlePlugin extends Plugin $schema->ensureTable('notice_title', array(new ColumnDef('notice_id', 'integer', null, true, 'PRI'), - new ColumnDef('title', 'varchar', 255, false))); + new ColumnDef('title', 'varchar', Notice_title::MAXCHARS, false))); return true; } @@ -114,11 +114,42 @@ class NoticeTitlePlugin extends Plugin 'id' => 'notice_title', 'name' => 'notice_title', 'size' => 40, + 'maxlength' => Notice_title::MAXCHARS, 'value' => _m('Title'), 'style' => 'color: 333333', 'onFocus' => 'this.value = ""; this.style = \'color: black\';')); return true; } + function onStartNoticeSaveWeb($action, &$authorId, &$text, &$options) + { + $title = $action->trimmed('notice_title'); + if (!empty($title)) { + if (mb_strlen($title) > Notice_title::MAXCHARS) { + throw new Exception(sprintf(_m("Notice title too long (max %d chars)", Notice_title::MAXCHARS))); + } + } + return true; + } + + function onEndNoticeSaveWeb($action, $notice) + { + if (!empty($notice)) { + + $title = $action->trimmed('notice_title'); + + if (!empty($title)) { + + $nt = new Notice_title(); + + $nt->notice_id = $notice->id; + $nt->title = $title; + + $nt->insert(); + } + } + + return true; + } } diff --git a/plugins/NoticeTitle/Notice_title.php b/plugins/NoticeTitle/Notice_title.php index ed71f13567..44d56b4968 100644 --- a/plugins/NoticeTitle/Notice_title.php +++ b/plugins/NoticeTitle/Notice_title.php @@ -47,6 +47,8 @@ require_once INSTALLDIR . '/classes/Memcached_DataObject.php'; class Notice_title extends Memcached_DataObject { + const MAXCHARS = 255; + public $__table = 'notice_title'; // table name public $notice_id; // int(4) primary_key not_null public $title; // varchar(255) From 67ff9ea49011fd8cc1c102c6fb236c47cd034342 Mon Sep 17 00:00:00 2001 From: Evan Prodromou Date: Fri, 13 Aug 2010 11:35:16 -0700 Subject: [PATCH 05/13] helper static method to get title text based on a notice --- plugins/NoticeTitle/Notice_title.php | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/plugins/NoticeTitle/Notice_title.php b/plugins/NoticeTitle/Notice_title.php index 44d56b4968..c2d1a83ca4 100644 --- a/plugins/NoticeTitle/Notice_title.php +++ b/plugins/NoticeTitle/Notice_title.php @@ -115,4 +115,22 @@ class Notice_title extends Memcached_DataObject { return array(false, false, false); } + + /** + * Get a notice title based on the notice + * + * @param Notice $notice Notice to fetch a title for + * + * @return string title of the notice, or null if none + */ + + static function fromNotice(Notice $notice) + { + $nt = Notice_title::staticGet('notice_id', $notice->id); + if (empty($nt)) { + return null; + } else { + return $nt->title; + } + } } From 91c914fa3b988c2e5b38b0cdff3fd2d596a6a0ce Mon Sep 17 00:00:00 2001 From: Evan Prodromou Date: Fri, 13 Aug 2010 11:35:36 -0700 Subject: [PATCH 06/13] show notice title for notices in a notice list --- plugins/NoticeTitle/NoticeTitlePlugin.php | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/plugins/NoticeTitle/NoticeTitlePlugin.php b/plugins/NoticeTitle/NoticeTitlePlugin.php index 86a74a4da5..e8377f5b0b 100644 --- a/plugins/NoticeTitle/NoticeTitlePlugin.php +++ b/plugins/NoticeTitle/NoticeTitlePlugin.php @@ -151,5 +151,16 @@ class NoticeTitlePlugin extends Plugin return true; } + + function onStartShowNoticeItem($nli) + { + $title = Notice_title::fromNotice($nli->notice); + + if (!empty($title)) { + $nli->out->element('h4', array('class' => 'notice_title'), $title); + } + + return true; + } } From ed8d8eb5eeedf3caf7f38b5e03519dada24abee1 Mon Sep 17 00:00:00 2001 From: Evan Prodromou Date: Fri, 13 Aug 2010 11:44:26 -0700 Subject: [PATCH 07/13] hooks to allow changing RSS content --- EVENTS.txt | 8 ++++ lib/apiaction.php | 101 ++++++++++++++++++++++++---------------------- 2 files changed, 61 insertions(+), 48 deletions(-) diff --git a/EVENTS.txt b/EVENTS.txt index f34fcc3da0..bc3e0ea90f 100644 --- a/EVENTS.txt +++ b/EVENTS.txt @@ -1056,3 +1056,11 @@ EndNoticeSaveWeb: after saving a notice through the Web interface - $action: action being executed (instance of NewNoticeAction) - $notice: notice that was saved +StartRssEntryArray: at the start of copying a notice to an array +- $notice: the notice being copied +- &$entry: the entry (empty at beginning) + +EndRssEntryArray: at the end of copying a notice to an array +- $notice: the notice being copied +- &$entry: the entry, with all the fields filled up + diff --git a/lib/apiaction.php b/lib/apiaction.php index 479a86ad80..cc98b9b6ec 100644 --- a/lib/apiaction.php +++ b/lib/apiaction.php @@ -462,66 +462,71 @@ class ApiAction extends Action function twitterRssEntryArray($notice) { - $profile = $notice->getProfile(); - $entry = array(); - // We trim() to avoid extraneous whitespace in the output + if (Event::handle('StartRssEntryArray', array($notice, &$entry))) { - $entry['content'] = common_xml_safe_str(trim($notice->rendered)); - $entry['title'] = $profile->nickname . ': ' . common_xml_safe_str(trim($notice->content)); - $entry['link'] = common_local_url('shownotice', array('notice' => $notice->id)); - $entry['published'] = common_date_iso8601($notice->created); + $profile = $notice->getProfile(); - $taguribase = TagURI::base(); - $entry['id'] = "tag:$taguribase:$entry[link]"; + // We trim() to avoid extraneous whitespace in the output - $entry['updated'] = $entry['published']; - $entry['author'] = $profile->getBestName(); + $entry['content'] = common_xml_safe_str(trim($notice->rendered)); + $entry['title'] = $profile->nickname . ': ' . common_xml_safe_str(trim($notice->content)); + $entry['link'] = common_local_url('shownotice', array('notice' => $notice->id)); + $entry['published'] = common_date_iso8601($notice->created); - // Enclosures - $attachments = $notice->attachments(); - $enclosures = array(); + $taguribase = TagURI::base(); + $entry['id'] = "tag:$taguribase:$entry[link]"; - foreach ($attachments as $attachment) { - $enclosure_o=$attachment->getEnclosure(); - if ($enclosure_o) { - $enclosure = array(); - $enclosure['url'] = $enclosure_o->url; - $enclosure['mimetype'] = $enclosure_o->mimetype; - $enclosure['size'] = $enclosure_o->size; - $enclosures[] = $enclosure; + $entry['updated'] = $entry['published']; + $entry['author'] = $profile->getBestName(); + + // Enclosures + $attachments = $notice->attachments(); + $enclosures = array(); + + foreach ($attachments as $attachment) { + $enclosure_o=$attachment->getEnclosure(); + if ($enclosure_o) { + $enclosure = array(); + $enclosure['url'] = $enclosure_o->url; + $enclosure['mimetype'] = $enclosure_o->mimetype; + $enclosure['size'] = $enclosure_o->size; + $enclosures[] = $enclosure; + } } - } - if (!empty($enclosures)) { - $entry['enclosures'] = $enclosures; - } - - // Tags/Categories - $tag = new Notice_tag(); - $tag->notice_id = $notice->id; - if ($tag->find()) { - $entry['tags']=array(); - while ($tag->fetch()) { - $entry['tags'][]=$tag->tag; + if (!empty($enclosures)) { + $entry['enclosures'] = $enclosures; } - } - $tag->free(); - // RSS Item specific - $entry['description'] = $entry['content']; - $entry['pubDate'] = common_date_rfc2822($notice->created); - $entry['guid'] = $entry['link']; + // Tags/Categories + $tag = new Notice_tag(); + $tag->notice_id = $notice->id; + if ($tag->find()) { + $entry['tags']=array(); + while ($tag->fetch()) { + $entry['tags'][]=$tag->tag; + } + } + $tag->free(); - if (isset($notice->lat) && isset($notice->lon)) { - // This is the format that GeoJSON expects stuff to be in. - // showGeoRSS() below uses it for XML output, so we reuse it - $entry['geo'] = array('type' => 'Point', - 'coordinates' => array((float) $notice->lat, - (float) $notice->lon)); - } else { - $entry['geo'] = null; + // RSS Item specific + $entry['description'] = $entry['content']; + $entry['pubDate'] = common_date_rfc2822($notice->created); + $entry['guid'] = $entry['link']; + + if (isset($notice->lat) && isset($notice->lon)) { + // This is the format that GeoJSON expects stuff to be in. + // showGeoRSS() below uses it for XML output, so we reuse it + $entry['geo'] = array('type' => 'Point', + 'coordinates' => array((float) $notice->lat, + (float) $notice->lon)); + } else { + $entry['geo'] = null; + } + + Event::handle('EndRssEntryArray', array($notice, &$entry)); } return $entry; From 96705b4ec5d9fc658a6add47777912bc1362f406 Mon Sep 17 00:00:00 2001 From: Evan Prodromou Date: Fri, 13 Aug 2010 11:50:33 -0700 Subject: [PATCH 08/13] set notice titles in RSS and Atom output --- plugins/NoticeTitle/NoticeTitlePlugin.php | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/plugins/NoticeTitle/NoticeTitlePlugin.php b/plugins/NoticeTitle/NoticeTitlePlugin.php index e8377f5b0b..c708a9fa0c 100644 --- a/plugins/NoticeTitle/NoticeTitlePlugin.php +++ b/plugins/NoticeTitle/NoticeTitlePlugin.php @@ -162,5 +162,27 @@ class NoticeTitlePlugin extends Plugin return true; } + + function onEndRssEntryArray($notice, &$entry) + { + $title = Notice_title::fromNotice($notice); + + if (!empty($title)) { + $entry['title'] = $title; + } + + return true; + } + + function onStartActivityTitle(&$notice, &$xs, &$output) + { + $title = Notice_title::fromNotice($notice); + + if (!empty($title)) { + $output = $title; + } + + return true; + } } From eff0b8e1aaf6c6c6d71b89aa068430c2077a12b0 Mon Sep 17 00:00:00 2001 From: Evan Prodromou Date: Fri, 13 Aug 2010 12:01:29 -0700 Subject: [PATCH 09/13] make notice title phpcs-clean --- plugins/NoticeTitle/NoticeTitlePlugin.php | 88 ++++++++++++++++++++--- 1 file changed, 80 insertions(+), 8 deletions(-) diff --git a/plugins/NoticeTitle/NoticeTitlePlugin.php b/plugins/NoticeTitle/NoticeTitlePlugin.php index c708a9fa0c..115e1c14cf 100644 --- a/plugins/NoticeTitle/NoticeTitlePlugin.php +++ b/plugins/NoticeTitle/NoticeTitlePlugin.php @@ -69,8 +69,15 @@ class NoticeTitlePlugin extends Plugin // For storing titles for notices $schema->ensureTable('notice_title', - array(new ColumnDef('notice_id', 'integer', null, true, 'PRI'), - new ColumnDef('title', 'varchar', Notice_title::MAXCHARS, false))); + array(new ColumnDef('notice_id', + 'integer', + null, + true, + 'PRI'), + new ColumnDef('title', + 'varchar', + Notice_title::MAXCHARS, + false))); return true; } @@ -97,41 +104,79 @@ class NoticeTitlePlugin extends Plugin } } + /** + * Provide plugin version information. + * + * This data is used when showing the version page. + * + * @param array &$versions array of version data arrays; see EVENTS.txt + * + * @return boolean hook value + */ + function onPluginVersion(&$versions) { + $url = 'http://status.net/wiki/Plugin:NoticeTitle'; + $versions[] = array('name' => 'NoticeTitle', 'version' => NOTICE_TITLE_PLUGIN_VERSION, 'author' => 'Evan Prodromou', - 'homepage' => 'http://status.net/wiki/Plugin:NoticeTitle', + 'homepage' => $url, 'rawdescription' => _m('Adds optional titles to notices')); return true; } + /** + * Show title entry when showing notice form + * + * @param Form $form Form being shown + * + * @return boolean hook value + */ + function onStartShowNoticeFormData($form) { $form->out->element('input', array('type' => 'text', 'id' => 'notice_title', 'name' => 'notice_title', 'size' => 40, - 'maxlength' => Notice_title::MAXCHARS, - 'value' => _m('Title'), - 'style' => 'color: 333333', - 'onFocus' => 'this.value = ""; this.style = \'color: black\';')); + 'maxlength' => Notice_title::MAXCHARS)); return true; } + /** + * Validate notice title before saving + * + * @param Action $action NewNoticeAction being executed + * @param integer &$authorId Author ID + * @param string &$text Text of the notice + * @param array &$options Options array + * + * @return boolean hook value + */ + function onStartNoticeSaveWeb($action, &$authorId, &$text, &$options) { $title = $action->trimmed('notice_title'); if (!empty($title)) { if (mb_strlen($title) > Notice_title::MAXCHARS) { - throw new Exception(sprintf(_m("Notice title too long (max %d chars)", Notice_title::MAXCHARS))); + throw new Exception(sprintf(_m("Notice title too long (max %d)", + Notice_title::MAXCHARS))); } } return true; } + /** + * Save notice title after notice is saved + * + * @param Action $action NewNoticeAction being executed + * @param Notice $notice Notice that was saved + * + * @return boolean hook value + */ + function onEndNoticeSaveWeb($action, $notice) { if (!empty($notice)) { @@ -152,6 +197,14 @@ class NoticeTitlePlugin extends Plugin return true; } + /** + * Show the notice title in lists + * + * @param NoticeListItem $nli NoticeListItem being shown + * + * @return boolean hook value + */ + function onStartShowNoticeItem($nli) { $title = Notice_title::fromNotice($nli->notice); @@ -163,6 +216,15 @@ class NoticeTitlePlugin extends Plugin return true; } + /** + * Show the notice title in RSS output + * + * @param Notice $notice Notice being shown + * @param array &$entry array of values used for RSS output + * + * @return boolean hook value + */ + function onEndRssEntryArray($notice, &$entry) { $title = Notice_title::fromNotice($notice); @@ -174,6 +236,16 @@ class NoticeTitlePlugin extends Plugin return true; } + /** + * Show the notice title in Atom output + * + * @param Notice &$notice Notice being shown + * @param XMLStringer &$xs output context + * @param string &$output string to be output as title + * + * @return boolean hook value + */ + function onStartActivityTitle(&$notice, &$xs, &$output) { $title = Notice_title::fromNotice($notice); From e6da476c1650fbb9e4cca5f2d9a418b3186d5d06 Mon Sep 17 00:00:00 2001 From: Evan Prodromou Date: Fri, 13 Aug 2010 12:04:30 -0700 Subject: [PATCH 10/13] make notice title phpcs-clean --- plugins/NoticeTitle/Notice_title.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/plugins/NoticeTitle/Notice_title.php b/plugins/NoticeTitle/Notice_title.php index c2d1a83ca4..b3b4fcc571 100644 --- a/plugins/NoticeTitle/Notice_title.php +++ b/plugins/NoticeTitle/Notice_title.php @@ -98,6 +98,8 @@ class Notice_title extends Memcached_DataObject /** * return key definitions for Memcached_DataObject + * + * @return array list mapping field names to key types */ function keyTypes() From 9b7536351b1efa5bf222fad1fb92b6dc9e33156f Mon Sep 17 00:00:00 2001 From: Evan Prodromou Date: Fri, 13 Aug 2010 12:22:58 -0700 Subject: [PATCH 11/13] hide the Whats Up Nickname if notice title enabled --- lib/noticeform.php | 3 ++- plugins/NoticeTitle/NoticeTitlePlugin.php | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/noticeform.php b/lib/noticeform.php index 84c20a5b3f..5140663569 100644 --- a/lib/noticeform.php +++ b/lib/noticeform.php @@ -169,7 +169,8 @@ class NoticeForm extends Form function formData() { if (Event::handle('StartShowNoticeFormData', array($this))) { - $this->out->element('label', array('for' => 'notice_data-text'), + $this->out->element('label', array('for' => 'notice_data-text', + 'id' => 'notice_data-text-label'), sprintf(_('What\'s up, %s?'), $this->user->nickname)); // XXX: vary by defined max size $this->out->element('textarea', array('id' => 'notice_data-text', diff --git a/plugins/NoticeTitle/NoticeTitlePlugin.php b/plugins/NoticeTitle/NoticeTitlePlugin.php index 115e1c14cf..18ffed4be2 100644 --- a/plugins/NoticeTitle/NoticeTitlePlugin.php +++ b/plugins/NoticeTitle/NoticeTitlePlugin.php @@ -137,6 +137,7 @@ class NoticeTitlePlugin extends Plugin function onStartShowNoticeFormData($form) { + $form->out->element('style', null, 'label#notice_data-text-label { display: none }'); $form->out->element('input', array('type' => 'text', 'id' => 'notice_title', 'name' => 'notice_title', From 6d89aa09317719dd4f682f75a10e8e9b50132b5c Mon Sep 17 00:00:00 2001 From: Evan Prodromou Date: Sat, 14 Aug 2010 11:54:20 -0700 Subject: [PATCH 12/13] on deleting a notice --- EVENTS.txt | 2 ++ classes/Notice.php | 19 +++++++++++-------- 2 files changed, 13 insertions(+), 8 deletions(-) diff --git a/EVENTS.txt b/EVENTS.txt index bc3e0ea90f..1a3b2594a2 100644 --- a/EVENTS.txt +++ b/EVENTS.txt @@ -1064,3 +1064,5 @@ EndRssEntryArray: at the end of copying a notice to an array - $notice: the notice being copied - &$entry: the entry, with all the fields filled up +NoticeDeleteRelated: at the beginning of deleting related fields to a notice +- $notice: notice being deleted diff --git a/classes/Notice.php b/classes/Notice.php index 0eeebfadf3..686dfc031e 100644 --- a/classes/Notice.php +++ b/classes/Notice.php @@ -121,16 +121,19 @@ class Notice extends Memcached_DataObject $deleted->insert(); } - // Clear related records + if (Event::handle('NoticeDeleteRelated', array($this))) { - $this->clearReplies(); - $this->clearRepeats(); - $this->clearFaves(); - $this->clearTags(); - $this->clearGroupInboxes(); + // Clear related records - // NOTE: we don't clear inboxes - // NOTE: we don't clear queue items + $this->clearReplies(); + $this->clearRepeats(); + $this->clearFaves(); + $this->clearTags(); + $this->clearGroupInboxes(); + + // NOTE: we don't clear inboxes + // NOTE: we don't clear queue items + } $result = parent::delete(); From 401cf36de3bcce681f95344cc479f0594014b028 Mon Sep 17 00:00:00 2001 From: Evan Prodromou Date: Sat, 14 Aug 2010 11:58:54 -0700 Subject: [PATCH 13/13] handle deletion of notice --- plugins/NoticeTitle/NoticeTitlePlugin.php | 23 ++++++++++++++++++++++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/plugins/NoticeTitle/NoticeTitlePlugin.php b/plugins/NoticeTitle/NoticeTitlePlugin.php index 18ffed4be2..f7fb1e4d00 100644 --- a/plugins/NoticeTitle/NoticeTitlePlugin.php +++ b/plugins/NoticeTitle/NoticeTitlePlugin.php @@ -137,7 +137,9 @@ class NoticeTitlePlugin extends Plugin function onStartShowNoticeFormData($form) { - $form->out->element('style', null, 'label#notice_data-text-label { display: none }'); + $form->out->element('style', + null, + 'label#notice_data-text-label { display: none }'); $form->out->element('input', array('type' => 'text', 'id' => 'notice_title', 'name' => 'notice_title', @@ -257,5 +259,24 @@ class NoticeTitlePlugin extends Plugin return true; } + + /** + * Remove title when the notice is deleted + * + * @param Notice $notice Notice being deleted + * + * @return boolean hook value + */ + + function onNoticeDeleteRelated($notice) + { + $nt = Notice_title::staticGet('notice_id', $notice->id); + + if (!empty($nt)) { + $nt->delete(); + } + + return true; + } }