GNUsocial/gnu-social
4
0
Fork 1
Code Issues Releases Wiki Activity

* translator documentation updates.

Browse Source 
* added FIXMEs in actions/showgroup.php.
* superfluous whitespace removed.
This commit is contained in:
Siebrand Mazeland 2010-10-30 14:36:54 +02:00
parent 8391058ea4
commit 234b03d945
3 changed files with 43 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

60
actions/showgroup.php
View File

@ -46,10 +46,8 @@ define('MEMBERS_PER_SECTION', 27);
* @license http://www.fsf.org/licensing/licenses/agpl-3.0.html GNU Affero General Public License version 3.0 * @license http://www.fsf.org/licensing/licenses/agpl-3.0.html GNU Affero General Public License version 3.0
* @link http://status.net/ * @link http://status.net/
*/ */
class ShowgroupAction extends GroupDesignAction class ShowgroupAction extends GroupDesignAction
{ {
/** page we're viewing. */ /** page we're viewing. */
var $page = null; var $page = null;
@ -58,7 +56,6 @@ class ShowgroupAction extends GroupDesignAction
* *
* @return boolean true * @return boolean true
*/ */
function isReadOnly($args) function isReadOnly($args)
{ {
return true; return true;
@ -69,18 +66,21 @@ class ShowgroupAction extends GroupDesignAction
* *
* @return string page title, with page number * @return string page title, with page number
*/ */
function title() function title()
{ {
if (!empty($this->group->fullname)) { if (!empty($this->group->fullname)) {
// @todo FIXME: Needs proper i18n. Maybe use a generic method for this?
$base = $this->group->fullname . ' (' . $this->group->nickname . ')'; $base = $this->group->fullname . ' (' . $this->group->nickname . ')';
} else { } else {
$base = $this->group->nickname; $base = $this->group->nickname;
} }
if ($this->page == 1) { if ($this->page == 1) {
// TRANS: Page title for first group page. %s is a group name.
return sprintf(_('%s group'), $base); return sprintf(_('%s group'), $base);
} else { } else {
// TRANS: Page title for any but first group page.
// TRANS: %1$s is a group name, $2$s is a page number.
return sprintf(_('%1$s group, page %2$d'), return sprintf(_('%1$s group, page %2$d'),
$base, $base,
$this->page); $this->page);
@ -96,7 +96,6 @@ class ShowgroupAction extends GroupDesignAction
* *
* @return boolean success flag * @return boolean success flag
*/ */
function prepare($args) function prepare($args)
{ {
parent::prepare($args); parent::prepare($args);
@ -118,6 +117,7 @@ class ShowgroupAction extends GroupDesignAction
} }
if (!$nickname) { if (!$nickname) {
// TRANS: Client error displayed if no nickname argument was given requesting a group page.
$this->clientError(_('No nickname.'), 404); $this->clientError(_('No nickname.'), 404);
return false; return false;
} }
@ -135,6 +135,7 @@ class ShowgroupAction extends GroupDesignAction
return false; return false;
} else { } else {
common_log(LOG_NOTICE, "Couldn't find local group for nickname '$nickname'"); common_log(LOG_NOTICE, "Couldn't find local group for nickname '$nickname'");
// TRANS: Client error displayed if no remote group with a given name was found requesting group page.
$this->clientError(_('No such group.'), 404); $this->clientError(_('No such group.'), 404);
return false; return false;
} }
@ -143,6 +144,7 @@ class ShowgroupAction extends GroupDesignAction
$this->group = User_group::staticGet('id', $local->group_id); $this->group = User_group::staticGet('id', $local->group_id);
if (!$this->group) { if (!$this->group) {
// TRANS: Client error displayed if no local group with a given name was found requesting group page.
$this->clientError(_('No such group.'), 404); $this->clientError(_('No such group.'), 404);
return false; return false;
} }
@ -160,7 +162,6 @@ class ShowgroupAction extends GroupDesignAction
* *
* @return void * @return void
*/ */
function handle($args) function handle($args)
{ {
$this->showPage(); $this->showPage();
@ -171,7 +172,6 @@ class ShowgroupAction extends GroupDesignAction
* *
* @return void * @return void
*/ */
function showLocalNav() function showLocalNav()
{ {
$nav = new GroupNav($this, $this->group); $nav = new GroupNav($this, $this->group);
@ -183,7 +183,6 @@ class ShowgroupAction extends GroupDesignAction
* *
* Shows a group profile and a list of group notices * Shows a group profile and a list of group notices
*/ */
function showContent() function showContent()
{ {
$this->showGroupProfile(); $this->showGroupProfile();
@ -195,7 +194,6 @@ class ShowgroupAction extends GroupDesignAction
* *
* @return void * @return void
*/ */
function showGroupNotices() function showGroupNotices()
{ {
$notice = $this->group->getNotices(($this->page-1)*NOTICES_PER_PAGE, $notice = $this->group->getNotices(($this->page-1)*NOTICES_PER_PAGE,
@ -218,15 +216,16 @@ class ShowgroupAction extends GroupDesignAction
* *
* @return void * @return void
*/ */
function showGroupProfile() function showGroupProfile()
{ {
$this->elementStart('div', array('id' => 'i', $this->elementStart('div', array('id' => 'i',
'class' => 'entity_profile vcard author')); 'class' => 'entity_profile vcard author'));
// TRANS: Group profile header (h2). Text hidden by default.
$this->element('h2', null, _('Group profile')); $this->element('h2', null, _('Group profile'));
$this->elementStart('dl', 'entity_depiction'); $this->elementStart('dl', 'entity_depiction');
// TRANS: Label for group avatar (dt). Text hidden by default.
$this->element('dt', null, _('Avatar')); $this->element('dt', null, _('Avatar'));
$this->elementStart('dd'); $this->elementStart('dd');
@ -242,6 +241,7 @@ class ShowgroupAction extends GroupDesignAction
$this->elementEnd('dl'); $this->elementEnd('dl');
$this->elementStart('dl', 'entity_nickname'); $this->elementStart('dl', 'entity_nickname');
// TRANS: Label for group nickname (dt). Text hidden by default.
$this->element('dt', null, _('Nickname')); $this->element('dt', null, _('Nickname'));
$this->elementStart('dd'); $this->elementStart('dd');
$hasFN = ($this->group->fullname) ? 'nickname url uid' : 'fn org nickname url uid'; $hasFN = ($this->group->fullname) ? 'nickname url uid' : 'fn org nickname url uid';
@ -253,6 +253,7 @@ class ShowgroupAction extends GroupDesignAction
if ($this->group->fullname) { if ($this->group->fullname) {
$this->elementStart('dl', 'entity_fn'); $this->elementStart('dl', 'entity_fn');
// TRANS: Label for full group name (dt). Text hidden by default.
$this->element('dt', null, _('Full name')); $this->element('dt', null, _('Full name'));
$this->elementStart('dd'); $this->elementStart('dd');
$this->element('span', 'fn org', $this->group->fullname); $this->element('span', 'fn org', $this->group->fullname);
@ -262,6 +263,7 @@ class ShowgroupAction extends GroupDesignAction
if ($this->group->location) { if ($this->group->location) {
$this->elementStart('dl', 'entity_location'); $this->elementStart('dl', 'entity_location');
// TRANS: Label for group location (dt). Text hidden by default.
$this->element('dt', null, _('Location')); $this->element('dt', null, _('Location'));
$this->element('dd', 'label', $this->group->location); $this->element('dd', 'label', $this->group->location);
$this->elementEnd('dl'); $this->elementEnd('dl');
@ -269,6 +271,7 @@ class ShowgroupAction extends GroupDesignAction
if ($this->group->homepage) { if ($this->group->homepage) {
$this->elementStart('dl', 'entity_url'); $this->elementStart('dl', 'entity_url');
// TRANS: Label for group URL (dt). Text hidden by default.
$this->element('dt', null, _('URL')); $this->element('dt', null, _('URL'));
$this->elementStart('dd'); $this->elementStart('dd');
$this->element('a', array('href' => $this->group->homepage, $this->element('a', array('href' => $this->group->homepage,
@ -280,6 +283,7 @@ class ShowgroupAction extends GroupDesignAction
if ($this->group->description) { if ($this->group->description) {
$this->elementStart('dl', 'entity_note'); $this->elementStart('dl', 'entity_note');
// TRANS: Label for group description or group note (dt). Text hidden by default.
$this->element('dt', null, _('Note')); $this->element('dt', null, _('Note'));
$this->element('dd', 'note', $this->group->description); $this->element('dd', 'note', $this->group->description);
$this->elementEnd('dl'); $this->elementEnd('dl');
@ -290,6 +294,7 @@ class ShowgroupAction extends GroupDesignAction
if (!empty($aliases)) { if (!empty($aliases)) {
$this->elementStart('dl', 'entity_aliases'); $this->elementStart('dl', 'entity_aliases');
// TRANS: Label for group aliases (dt). Text hidden by default.
$this->element('dt', null, _('Aliases')); $this->element('dt', null, _('Aliases'));
$this->element('dd', 'aliases', implode(' ', $aliases)); $this->element('dd', 'aliases', implode(' ', $aliases));
$this->elementEnd('dl'); $this->elementEnd('dl');
@ -300,6 +305,7 @@ class ShowgroupAction extends GroupDesignAction
$cur = common_current_user(); $cur = common_current_user();
$this->elementStart('div', 'entity_actions'); $this->elementStart('div', 'entity_actions');
// TRANS: Group actions header (h2). Text hidden by default.
$this->element('h2', null, _('Group actions')); $this->element('h2', null, _('Group actions'));
$this->elementStart('ul'); $this->elementStart('ul');
$this->elementStart('li', 'entity_subscribe'); $this->elementStart('li', 'entity_subscribe');
@ -331,7 +337,6 @@ class ShowgroupAction extends GroupDesignAction
* *
* @return void * @return void
*/ */
function getFeeds() function getFeeds()
{ {
$url = $url =
@ -341,23 +346,27 @@ class ShowgroupAction extends GroupDesignAction
return array(new Feed(Feed::RSS1, return array(new Feed(Feed::RSS1,
common_local_url('grouprss', common_local_url('grouprss',
array('nickname' => $this->group->nickname)), array('nickname' => $this->group->nickname)),
// TRANS: Tooltip for feed link. %s is a group nickname.
sprintf(_('Notice feed for %s group (RSS 1.0)'), sprintf(_('Notice feed for %s group (RSS 1.0)'),
$this->group->nickname)), $this->group->nickname)),
new Feed(Feed::RSS2, new Feed(Feed::RSS2,
common_local_url('ApiTimelineGroup', common_local_url('ApiTimelineGroup',
array('format' => 'rss', array('format' => 'rss',
'id' => $this->group->id)), 'id' => $this->group->id)),
// TRANS: Tooltip for feed link. %s is a group nickname.
sprintf(_('Notice feed for %s group (RSS 2.0)'), sprintf(_('Notice feed for %s group (RSS 2.0)'),
$this->group->nickname)), $this->group->nickname)),
new Feed(Feed::ATOM, new Feed(Feed::ATOM,
common_local_url('ApiTimelineGroup', common_local_url('ApiTimelineGroup',
array('format' => 'atom', array('format' => 'atom',
'id' => $this->group->id)), 'id' => $this->group->id)),
// TRANS: Tooltip for feed link. %s is a group nickname.
sprintf(_('Notice feed for %s group (Atom)'), sprintf(_('Notice feed for %s group (Atom)'),
$this->group->nickname)), $this->group->nickname)),
new Feed(Feed::FOAF, new Feed(Feed::FOAF,
common_local_url('foafgroup', common_local_url('foafgroup',
array('nickname' => $this->group->nickname)), array('nickname' => $this->group->nickname)),
// TRANS: Tooltip for feed link. %s is a group nickname.
sprintf(_('FOAF for %s group'), sprintf(_('FOAF for %s group'),
$this->group->nickname))); $this->group->nickname)));
} }
@ -367,7 +376,6 @@ class ShowgroupAction extends GroupDesignAction
* *
* @return void * @return void
*/ */
function showSections() function showSections()
{ {
$this->showMembers(); $this->showMembers();
@ -382,7 +390,6 @@ class ShowgroupAction extends GroupDesignAction
* *
* @return void * @return void
*/ */
function showMembers() function showMembers()
{ {
$member = $this->group->getMembers(0, MEMBERS_PER_SECTION); $member = $this->group->getMembers(0, MEMBERS_PER_SECTION);
@ -396,17 +403,22 @@ class ShowgroupAction extends GroupDesignAction
if (Event::handle('StartShowGroupMembersMiniList', array($this))) { if (Event::handle('StartShowGroupMembersMiniList', array($this))) {
// TRANS: Header for mini list of group members on a group page (h2).
$this->element('h2', null, _('Members')); $this->element('h2', null, _('Members'));
$gmml = new GroupMembersMiniList($member, $this); $gmml = new GroupMembersMiniList($member, $this);
$cnt = $gmml->show(); $cnt = $gmml->show();
if ($cnt == 0) { if ($cnt == 0) {
// TRANS: Description for mini list of group members on a group page when the group has no members.
$this->element('p', null, _('(None)')); $this->element('p', null, _('(None)'));
} }
// @todo FIXME: Should be shown if a group has more than 27 members, but I do not see it displayed at
// for example http://identi.ca/group/statusnet. Broken?
if ($cnt > MEMBERS_PER_SECTION) { if ($cnt > MEMBERS_PER_SECTION) {
$this->element('a', array('href' => common_local_url('groupmembers', $this->element('a', array('href' => common_local_url('groupmembers',
array('nickname' => $this->group->nickname))), array('nickname' => $this->group->nickname))),
// TRANS: Link to all group members from mini list of group members if group has more than n members.
_('All members')); _('All members'));
} }
@ -421,7 +433,6 @@ class ShowgroupAction extends GroupDesignAction
* *
* @return void * @return void
*/ */
function showAdmins() function showAdmins()
{ {
$adminSection = new GroupAdminSection($this, $this->group); $adminSection = new GroupAdminSection($this, $this->group);
@ -433,22 +444,26 @@ class ShowgroupAction extends GroupDesignAction
* *
* @return void * @return void
*/ */
function showStatistics() function showStatistics()
{ {
$this->elementStart('div', array('id' => 'entity_statistics', $this->elementStart('div', array('id' => 'entity_statistics',
'class' => 'section')); 'class' => 'section'));
// TRANS: Header for group statistics on a group page (h2).
$this->element('h2', null, _('Statistics')); $this->element('h2', null, _('Statistics'));
$this->elementStart('dl', 'entity_created'); $this->elementStart('dl', 'entity_created');
$this->element('dt', null, _('Created')); // @todo FIXME: i18n issue. This label gets a colon added from somewhere. Should be part of the message.
// TRANS: Label for creation date in statistics on group page.
$this->element('dt', null, _m('LABEL','Created'));
$this->element('dd', null, date('j M Y', $this->element('dd', null, date('j M Y',
strtotime($this->group->created))); strtotime($this->group->created)));
$this->elementEnd('dl'); $this->elementEnd('dl');
$this->elementStart('dl', 'entity_members'); $this->elementStart('dl', 'entity_members');
$this->element('dt', null, _('Members')); // @todo FIXME: i18n issue. This label gets a colon added from somewhere. Should be part of the message.
// TRANS: Label for member count in statistics on group page.
$this->element('dt', null, _m('LABEL','Members'));
$this->element('dd', null, $this->group->getMemberCount()); $this->element('dd', null, $this->group->getMemberCount());
$this->elementEnd('dl'); $this->elementEnd('dl');
@ -458,12 +473,21 @@ class ShowgroupAction extends GroupDesignAction
function showAnonymousMessage() function showAnonymousMessage()
{ {
if (!(common_config('site','closed') || common_config('site','inviteonly'))) { if (!(common_config('site','closed') || common_config('site','inviteonly'))) {
// @todo FIXME: use group full name here if available instead of (uglier) primary alias.
// TRANS: Notice on group pages for anonymous users for StatusNet sites that accept new registrations.
// TRANS: **%s** is the group alias, %%%%site.name%%%% is the site name,
// TRANS: %%%%action.register%%%% is the URL for registration, %%%%doc.help%%%% is a URL to help.
// TRANS: This message contains Markdown links. Ensure they are formatted correctly: [Description](link).
$m = sprintf(_('**%s** is a user group on %%%%site.name%%%%, a [micro-blogging](http://en.wikipedia.org/wiki/Micro-blogging) service ' . $m = sprintf(_('**%s** is a user group on %%%%site.name%%%%, a [micro-blogging](http://en.wikipedia.org/wiki/Micro-blogging) service ' .
'based on the Free Software [StatusNet](http://status.net/) tool. Its members share ' . 'based on the Free Software [StatusNet](http://status.net/) tool. Its members share ' .
'short messages about their life and interests. '. 'short messages about their life and interests. '.
'[Join now](%%%%action.register%%%%) to become part of this group and many more! ([Read more](%%%%doc.help%%%%))'), '[Join now](%%%%action.register%%%%) to become part of this group and many more! ([Read more](%%%%doc.help%%%%))'),
$this->group->nickname); $this->group->nickname);
} else { } else {
// @todo FIXME: use group full name here if available instead of (uglier) primary alias.
// TRANS: Notice on group pages for anonymous users for StatusNet sites that accept no new registrations.
// TRANS: **%s** is the group alias, %%%%site.name%%%% is the site name,
// TRANS: This message contains Markdown links. Ensure they are formatted correctly: [Description](link).
$m = sprintf(_('**%s** is a user group on %%%%site.name%%%%, a [micro-blogging](http://en.wikipedia.org/wiki/Micro-blogging) service ' . $m = sprintf(_('**%s** is a user group on %%%%site.name%%%%, a [micro-blogging](http://en.wikipedia.org/wiki/Micro-blogging) service ' .
'based on the Free Software [StatusNet](http://status.net/) tool. Its members share ' . 'based on the Free Software [StatusNet](http://status.net/) tool. Its members share ' .
'short messages about their life and interests. '), 'short messages about their life and interests. '),
@ -492,6 +516,7 @@ class GroupAdminSection extends ProfileSection
function title() function title()
{ {
// TRANS: Header for list of group administrators on a group page (h2).
return _('Admins'); return _('Admins');
} }
@ -527,4 +552,3 @@ class GroupMembersMiniListItem extends ProfileMiniListItem
return $aAttrs; return $aAttrs;
} }
} }

1
lib/feedlist.php
View File

@ -62,6 +62,7 @@ class FeedList extends Widget
if (!empty($feeds)) { if (!empty($feeds)) {
$this->out->elementStart('div', array('id' => 'export_data', $this->out->elementStart('div', array('id' => 'export_data',
'class' => 'section')); 'class' => 'section'));
// TRANS: Header for feed links (h2).
$this->out->element('h2', null, _('Feeds')); $this->out->element('h2', null, _('Feeds'));
$this->out->elementStart('ul', array('class' => 'xoxo')); $this->out->elementStart('ul', array('class' => 'xoxo'));

9
lib/uapplugin.php
View File

@ -51,7 +51,6 @@ if (!defined('STATUSNET') && !defined('LACONICA')) {
* @license http://www.fsf.org/licensing/licenses/agpl-3.0.html GNU Affero General Public License version 3.0 * @license http://www.fsf.org/licensing/licenses/agpl-3.0.html GNU Affero General Public License version 3.0
* @link http://status.net/ * @link http://status.net/
*/ */
abstract class UAPPlugin extends Plugin abstract class UAPPlugin extends Plugin
{ {
public $mediumRectangle = null; public $mediumRectangle = null;
@ -66,7 +65,6 @@ abstract class UAPPlugin extends Plugin
* *
* @return boolean hook flag * @return boolean hook flag
*/ */
function onEndShowStatusNetStyles($action) function onEndShowStatusNetStyles($action)
{ {
// XXX: allow override by theme // XXX: allow override by theme
@ -81,7 +79,6 @@ abstract class UAPPlugin extends Plugin
* *
* @return boolean hook flag * @return boolean hook flag
*/ */
function onStartShowAside($action) function onStartShowAside($action)
{ {
if (!is_null($this->mediumRectangle)) { if (!is_null($this->mediumRectangle)) {
@ -144,7 +141,6 @@ abstract class UAPPlugin extends Plugin
* *
* @return boolean hook flag * @return boolean hook flag
*/ */
function onStartShowSections($action) function onStartShowSections($action)
{ {
if (!is_null($this->rectangle)) { if (!is_null($this->rectangle)) {
@ -165,7 +161,6 @@ abstract class UAPPlugin extends Plugin
* *
* @return boolean hook flag * @return boolean hook flag
*/ */
function onEndShowAside($action) function onEndShowAside($action)
{ {
if (!is_null($this->wideSkyscraper)) { if (!is_null($this->wideSkyscraper)) {
@ -187,7 +182,6 @@ abstract class UAPPlugin extends Plugin
* *
* @return void * @return void
*/ */
abstract protected function showMediumRectangle($action); abstract protected function showMediumRectangle($action);
/** /**
@ -197,7 +191,6 @@ abstract class UAPPlugin extends Plugin
* *
* @return void * @return void
*/ */
abstract protected function showRectangle($action); abstract protected function showRectangle($action);
/** /**
@ -207,7 +200,6 @@ abstract class UAPPlugin extends Plugin
* *
* @return void * @return void
*/ */
abstract protected function showWideSkyscraper($action); abstract protected function showWideSkyscraper($action);
/** /**
@ -217,6 +209,5 @@ abstract class UAPPlugin extends Plugin
* *
* @return void * @return void
*/ */
abstract protected function showLeaderboard($action); abstract protected function showLeaderboard($action);
} }