Should fix spurious 'nickname taken' and 'email taken' errors on registration. Form's checks for existing nicks & emails would incorrectly return true on the second lookup due to bad interaction with negative caching.

(was checking $obj !== false but we return null now on negative cache hits, with false for cache misses)
This commit is contained in:
Brion Vibber 2010-02-04 13:08:34 -08:00
parent 5a1cbdc6f1
commit 239b88025e
1 changed files with 2 additions and 2 deletions

View File

@ -280,7 +280,7 @@ class RegisterAction extends Action
function nicknameExists($nickname) function nicknameExists($nickname)
{ {
$user = User::staticGet('nickname', $nickname); $user = User::staticGet('nickname', $nickname);
return ($user !== false); return is_object($user);
} }
/** /**
@ -300,7 +300,7 @@ class RegisterAction extends Action
return false; return false;
} }
$user = User::staticGet('email', $email); $user = User::staticGet('email', $email);
return ($user !== false); return is_object($user);
} }
// overrrided to add entry-title class // overrrided to add entry-title class