OStatus: pull best-sized avatar image (96x96 if found, otherwise largest, otherwise if none labeled takes the first)

This commit is contained in:
Brion Vibber 2010-02-25 18:51:44 -08:00
parent c8ddcbe0d3
commit 2feb09f434
2 changed files with 55 additions and 4 deletions

View File

@ -360,6 +360,25 @@ class ActivityUtils
return null; return null;
} }
static function getLinks(DOMNode $element, $rel, $type=null)
{
$links = $element->getElementsByTagnameNS(self::ATOM, self::LINK);
$out = array();
foreach ($links as $link) {
$linkRel = $link->getAttribute(self::REL);
$linkType = $link->getAttribute(self::TYPE);
if ($linkRel == $rel &&
(is_null($type) || $linkType == $type)) {
$out[] = $link;
}
}
return $out;
}
/** /**
* Gets the first child element with the given tag * Gets the first child element with the given tag
* *
@ -472,6 +491,24 @@ class AvatarLink
public $type; public $type;
public $size; public $size;
public $width; public $width;
public $height;
function __construct($element=null)
{
if ($element) {
// @fixme use correct namespaces
$this->url = $element->getAttribute('href');
$this->type = $element->getAttribute('type');
$width = $element->getAttribute('media:width');
if ($width != null) {
$this->width = intval($width);
}
$height = $element->getAttribute('media:height');
if ($height != null) {
$this->height = intval($height);
}
}
}
static function fromAvatar($avatar) static function fromAvatar($avatar)
{ {
@ -640,8 +677,10 @@ class ActivityObject
if ($this->type == self::PERSON || $this->type == self::GROUP) { if ($this->type == self::PERSON || $this->type == self::GROUP) {
$this->displayName = $this->title; $this->displayName = $this->title;
// @fixme we may have multiple avatars with different resolutions specified $avatars = ActivityUtils::getLinks($element, 'avatar');
$this->avatar = ActivityUtils::getLink($element, 'avatar'); foreach ($avatars as $link) {
$this->avatarLinks[] = new AvatarLink($link);
}
$this->poco = new PoCo($element); $this->poco = new PoCo($element);
} }

View File

@ -912,8 +912,20 @@ class Ostatus_profile extends Memcached_DataObject
protected static function getActivityObjectAvatar($object, $hints=array()) protected static function getActivityObjectAvatar($object, $hints=array())
{ {
if ($object->avatar) { if ($object->avatarLinks) {
return $object->avatar; $best = false;
// Take the exact-size avatar, or the largest avatar, or the first avatar if all sizeless
foreach ($object->avatarLinks as $avatar) {
if ($avatar->width == AVATAR_PROFILE_SIZE && $avatar->height = AVATAR_PROFILE_SIZE) {
// Exact match!
$best = $avatar;
break;
}
if (!$best || $avatar->width > $best->width) {
$best = $avatar;
}
}
return $best->url;
} else if (array_key_exists('avatar', $hints)) { } else if (array_key_exists('avatar', $hints)) {
return $hints['avatar']; return $hints['avatar'];
} }