From 052466ceab9666b30b6ee38bbb5774b1070618ad Mon Sep 17 00:00:00 2001 From: Sarven Capadisli Date: Thu, 18 Mar 2010 14:26:30 +0100 Subject: [PATCH 1/3] Using … (hellip) instead of "more" for link text --- plugins/OStatus/classes/Ostatus_profile.php | 11 ++++------- theme/base/css/display.css | 6 ------ 2 files changed, 4 insertions(+), 13 deletions(-) diff --git a/plugins/OStatus/classes/Ostatus_profile.php b/plugins/OStatus/classes/Ostatus_profile.php index 7ea8ff633b..e47b6973d7 100644 --- a/plugins/OStatus/classes/Ostatus_profile.php +++ b/plugins/OStatus/classes/Ostatus_profile.php @@ -546,7 +546,6 @@ class Ostatus_profile extends Memcached_DataObject $shortSummary = substr($shortSummary, 0, Notice::maxContent() - (mb_strlen($url) + 2)); - $shortSummary .= '…'; $content = $shortSummary . ' ' . $url; // We mark up the attachment link specially for the HTML output @@ -554,12 +553,10 @@ class Ostatus_profile extends Memcached_DataObject $attachUrl = common_local_url('attachment', array('attachment' => $attachment->id)); $rendered = common_render_text($shortSummary) . - ' ' . - '' . - // TRANS: expansion link for too-long remote messages - htmlspecialchars(_m('more')) . + '' . + '…' . ''; } } diff --git a/theme/base/css/display.css b/theme/base/css/display.css index 9044021f5f..757ce7ff1b 100644 --- a/theme/base/css/display.css +++ b/theme/base/css/display.css @@ -1288,12 +1288,6 @@ padding-left:16px; .notice .attachment.more { padding-left:0; } -.notice .attachment.more:before { -content:'( '; -} -.notice .attachment.more:after { -content:' )'; -} .notice .attachment img { position:absolute; top:18px; From e2768b863578ef1b763ebcc9e5adfaea5dfba9d2 Mon Sep 17 00:00:00 2001 From: Sarven Capadisli Date: Thu, 18 Mar 2010 14:29:35 +0100 Subject: [PATCH 2/3] Using an icon to represent the action for more text --- theme/base/css/display.css | 9 +++++++++ theme/base/images/icons/icons-01.gif | Bin 4080 -> 4120 bytes theme/default/css/display.css | 4 +++- theme/identica/css/display.css | 4 +++- 4 files changed, 15 insertions(+), 2 deletions(-) diff --git a/theme/base/css/display.css b/theme/base/css/display.css index 757ce7ff1b..fdbf59781d 100644 --- a/theme/base/css/display.css +++ b/theme/base/css/display.css @@ -1284,6 +1284,15 @@ height:16px; position:relative; padding-left:16px; } +.notice .attachment.more { +text-indent:-9999px; +width:16px; +height:16px; +display:inline-block; +overflow:hidden; +vertical-align:middle; +} + #attachments .attachment, .notice .attachment.more { padding-left:0; diff --git a/theme/base/images/icons/icons-01.gif b/theme/base/images/icons/icons-01.gif index bf0f1230e5e16d75e630a487708d8a45ed4f6abf..e0850aa8823636a300abb7d6e0def853a841387e 100644 GIT binary patch delta 1444 zcmc(b{Zo<$0DyUc1obsgLP1R-P|46B@vFH8h=Phv{K_;H%`085GVQ~%0WTt^<^(FW zv%+RZs)b)Y{Fw(Y7DHb+1>UxHMcw|6$B#RTviRBjv68OTzl*E+nX{i~f ztPW!(ANFytGbR*NPf>gs$VdAfd>jjVJXI7L+M zELnq^U{^Y3n;X|u#kp1Ma^6N+vBjh6!@Sum51LVD{ASaKRGWw0aPE5Lg!FBdCIJ~E ziIQV@SSt^gUZPTX7B!QVp5XIYIfhGOnkgrYFXH_aG_Hl<`caQiCugfrjQ%M2c}kN& zJp%Daw@{?w$~4!|tJ1bnY7_RF7$;x>jZ7nKactc%dRrs&JbObI6q6%rpq-{xj5EjH z+)4_}4@E2RMU_wzc{pZqT*B1Y_BO0hSbDUc#l}L^S!=O6fi+^A7LXlP&CEHC!lo`= ztBu(<9;&}h9)^n8(RaUV+chT$xnblusa(d~Uxi+OdhR#I{Rii^le2|AT3@lFs)1qX zg$wBi-ZA5FPq@={mzsJZ*U)n@x0HARwkM=@&SQf!V~_?Z@RG`Dqm57_b-uj%MBTz} z9GA3&kZ-f7l)lAv9SYCa5vrNN@cnP*M@UNgf`!^rwlGS&(7iB5zxih2E@OQw&m$#D zWWJYI=^jr=iK4B*#1iI*a9gWI@x+R!<^0uP;J~0~_rYntl^=9O=~wZ-TZ@aex!;={ z*QF^RX17SJW+;Uqs|^`qBO(Ge-xoP~Wzw_F58@_OE{-rOJFNcc))>)E=)kh9alHh? z6;2&T?yC6-nKiJ2QoxrBsYmEP2=VbCuq4f^wmJn|v%4iz_SuuiurY!ju~+6)hw)Wm z*+e8JeAWEMiOaK)g;bqus(G^8sJ#Q_jawy_$?uPMB(nNIRT8U(&?hEbTMTja`i3_M zV!C+p`VYAU$Iuj6Sh;`{&f}o)blv`f)K zE!@k}@3he_!!~M>K?07O)dms9#ZJV|ft6qF;rM}MH#W_*QmwD?$w)=@5j{<~eEr^# z46@TY{$NRGGn?2=2AQ*5Zvzp K0UQ8epZyKkZdafH delta 1386 zcmV-w1(o`kAn+dyM@dFFIbj+ApbF>ykqkP2pa20JCmyQ+03;hLq}goNk>ddPRcDTN=|0OFfUS2RLn3l)h{xgMMus&J)}!avrA24WMR|= zNlDC3O_6^X58qo`-C-)(USDK^X4PR|k)Rj@-Dzu)xFH7Ma&g;rc9Gd61LJ&sk^MFd z=7xz{snKAl%HxWPlQ{t!1LBa5lT-mD59ODcZnf9@oHKT_*Xo&^lYs#I)i z!rzI&-+IO2`L0`g#^Qy=XuCJ5N0Z0b&!@%&v#*-HUArJJ`)b-cG|Jk$2 zlg(5P9NGROWlYn0&K zJ74))u?V{8kdO#jxNsSv^jJ;HQ2{Vw1i;$611ei?2*Slkl^qWxH50}frvxJF*4fGT z`Jcru1fnDXphE|M1R+NPQ82r0zQin2)(FsqK?@EkQg93z0pKBv59{(7hpTEL3({Py z{#cP5BzZ*>pr~5yI8ha3$&#}~=&n!|44yFPQ=F2wiIg7^u!qus?ZJ~t1U!G}gcf3m zvBny5sv)sbT zf?^=)2`PmP(+xP+fcXn9v!Jrz8fL7aPCVeKbImpJuoF)_%hWQaf;`sI4Kl;fBab}x z>`BfqUM~1X9fAx4PAc*2vyXo~xPbGGE2&VjU>=1)f(f7f{PIgb@_;i-D*l`lGU}75 zfRpJm#_SUhIj}+^$by1Exy_@QZaPah-9S=}8@Ch_Nl0>Y{>+I_E4SjPW|s(Tu~&DSY#yhTD-Kp}T^7R3d-N*XI}lO+V>;Ax=NN z7{4GOvh%IY9-{Pv4;IYyCgErGq zvl?m`g8;{HhL{=ffCx;W0vE`@20HM85R9M%CrCjJJ>h~F%wPr?q`?kqa6ujn;S)e8 z!VZ$Kgd0>)2frB>!V_MwaxGLL1}jIyex#5<8LS};G3df4vl$0K1tI>hfDG7x3wUV$ sP(l&7Q4<(K6G%c8ctH%Pfe_e15BLPLdJLKZ0ojuk57h=mUjYFCJDoFYjsO4v diff --git a/theme/default/css/display.css b/theme/default/css/display.css index c08a03061d..a283930e51 100644 --- a/theme/default/css/display.css +++ b/theme/default/css/display.css @@ -410,8 +410,10 @@ background-position: 0 -1714px; .notice .attachment { background-position:0 -394px; } -#attachments .attachment, .notice .attachment.more { +background-position:0 -2770px; +} +#attachments .attachment { background:none; } .notice-options .notice_reply { diff --git a/theme/identica/css/display.css b/theme/identica/css/display.css index 62a9e25d81..69d265a6b7 100644 --- a/theme/identica/css/display.css +++ b/theme/identica/css/display.css @@ -409,8 +409,10 @@ background-position: 0 -1714px; .notice .attachment { background-position:0 -394px; } -#attachments .attachment, .notice .attachment.more { +background-position:0 -2770px; +} +#attachments .attachment { background:none; } .notice-options .notice_reply { From 7dd701fbb38dea575db889d3723f9938dd0251d2 Mon Sep 17 00:00:00 2001 From: Sarven Capadisli Date: Thu, 18 Mar 2010 23:00:38 +0100 Subject: [PATCH 3/3] Added processing indicator for more anchor --- js/util.js | 1 + theme/default/css/display.css | 2 +- theme/identica/css/display.css | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/js/util.js b/js/util.js index 79fd40deba..60eeb418f6 100644 --- a/js/util.js +++ b/js/util.js @@ -402,6 +402,7 @@ var SN = { // StatusNet var attachment_more = notice.find('.attachment.more'); if (attachment_more.length > 0) { attachment_more.click(function() { + $(this).addClass(SN.C.S.Processing); $.get($(this).attr('href')+'/ajax', null, function(data) { notice.find('.entry-title .entry-content').html($(data).find('#attachment_view .entry-content').html()); }); diff --git a/theme/default/css/display.css b/theme/default/css/display.css index a283930e51..d89607ebe5 100644 --- a/theme/default/css/display.css +++ b/theme/default/css/display.css @@ -213,7 +213,7 @@ background-color:transparent; } #wrap form.processing input.submit, -.entity_actions a.processing, +#content a.processing, .dialogbox.processing .submit_dialogbox { background:#FFFFFF url(../../base/images/icons/icon_processing.gif) no-repeat 47% 47%; } diff --git a/theme/identica/css/display.css b/theme/identica/css/display.css index 69d265a6b7..1af853c496 100644 --- a/theme/identica/css/display.css +++ b/theme/identica/css/display.css @@ -214,7 +214,7 @@ background-color:transparent; } #wrap form.processing input.submit, -.entity_actions a.processing, +#content a.processing, .dialogbox.processing .submit_dialogbox { background:#FFFFFF url(../../base/images/icons/icon_processing.gif) no-repeat 47% 47%; }