GNUsocial/gnu-social
4
0
Fork 1
Code Issues Releases Wiki Activity

* translator documentation updated.

Browse Source 
* superfluous whitespace removed.
* added FIXMEs for missing documentation and un-i18n-able timestamps.
This commit is contained in:
Siebrand Mazeland 2010-10-31 01:16:59 +02:00
parent 08edd1fedf
commit 5406873007
3 changed files with 43 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
actions/groupunblock.php
View File

@ -32,7 +32,7 @@ if (!defined('STATUSNET') && !defined('LACONICA')) {
} }
/** /**
* Unlock a user from a group * Unblock a user from a group
* *
* @category Action * @category Action
* @package StatusNet * @package StatusNet
@ -40,7 +40,6 @@ if (!defined('STATUSNET') && !defined('LACONICA')) {
* @license http://www.fsf.org/licensing/licenses/agpl.html AGPLv3 * @license http://www.fsf.org/licensing/licenses/agpl.html AGPLv3
* @link http://status.net/ * @link http://status.net/
*/ */
class GroupunblockAction extends Action class GroupunblockAction extends Action
{ {
var $profile = null; var $profile = null;
@ -53,11 +52,11 @@ class GroupunblockAction extends Action
* *
* @return boolean success flag * @return boolean success flag
*/ */
function prepare($args) function prepare($args)
{ {
parent::prepare($args); parent::prepare($args);
if (!common_logged_in()) { if (!common_logged_in()) {
// TRANS: Client error displayed when trying to unblock a user from a group while not logged in.
$this->clientError(_('Not logged in.')); $this->clientError(_('Not logged in.'));
return false; return false;
} }
@ -68,11 +67,13 @@ class GroupunblockAction extends Action
} }
$id = $this->trimmed('unblockto'); $id = $this->trimmed('unblockto');
if (empty($id)) { if (empty($id)) {
// TRANS: Client error displayed when trying to unblock a user from a group without providing a profile.
$this->clientError(_('No profile specified.')); $this->clientError(_('No profile specified.'));
return false; return false;
} }
$this->profile = Profile::staticGet('id', $id); $this->profile = Profile::staticGet('id', $id);
if (empty($this->profile)) { if (empty($this->profile)) {
// TRANS: Client error displayed when trying to unblock a user from a group without providing an existing profile.
$this->clientError(_('No profile with that ID.')); $this->clientError(_('No profile with that ID.'));
return false; return false;
} }
@ -83,15 +84,18 @@ class GroupunblockAction extends Action
} }
$this->group = User_group::staticGet('id', $group_id); $this->group = User_group::staticGet('id', $group_id);
if (empty($this->group)) { if (empty($this->group)) {
// TRANS: Client error displayed when trying to unblock a user from a non-existing group.
$this->clientError(_('No such group.')); $this->clientError(_('No such group.'));
return false; return false;
} }
$user = common_current_user(); $user = common_current_user();
if (!$user->isAdmin($this->group)) { if (!$user->isAdmin($this->group)) {
// TRANS: Client error displayed when trying to unblock a user from a group without being an administrator for the group.
$this->clientError(_('Only an admin can unblock group members.'), 401); $this->clientError(_('Only an admin can unblock group members.'), 401);
return false; return false;
} }
if (!Group_block::isBlocked($this->group, $this->profile)) { if (!Group_block::isBlocked($this->group, $this->profile)) {
// TRANS: Client error displayed when trying to unblock a non-blocked user from a group.
$this->clientError(_('User is not blocked from group.')); $this->clientError(_('User is not blocked from group.'));
return false; return false;
} }
@ -105,7 +109,6 @@ class GroupunblockAction extends Action
* *
* @return void * @return void
*/ */
function handle($args) function handle($args)
{ {
parent::handle($args); parent::handle($args);
@ -119,12 +122,12 @@ class GroupunblockAction extends Action
* *
* @return void * @return void
*/ */
function unblockProfile() function unblockProfile()
{ {
$result = Group_block::unblockProfile($this->group, $this->profile); $result = Group_block::unblockProfile($this->group, $this->profile);
if (!$result) { if (!$result) {
// TRANS: Server error displayed when unblocking a user from a group fails because of an unknown error.
$this->serverError(_('Error removing the block.')); $this->serverError(_('Error removing the block.'));
return; return;
} }
@ -146,4 +149,3 @@ class GroupunblockAction extends Action
} }
} }
} }

57
actions/showmessage.php
View File

@ -26,8 +26,8 @@
* @license http://www.fsf.org/licensing/licenses/agpl-3.0.html GNU Affero General Public License version 3.0 * @license http://www.fsf.org/licensing/licenses/agpl-3.0.html GNU Affero General Public License version 3.0
* @link http://status.net/ * @link http://status.net/
*/ */
if (!defined('STATUSNET') && !defined('LACONICA')) { if (!defined('STATUSNET') && !defined('LACONICA')) {
exit(1); exit(1);
} }
require_once INSTALLDIR.'/lib/mailbox.php'; require_once INSTALLDIR.'/lib/mailbox.php';
@ -36,26 +36,24 @@ require_once INSTALLDIR.'/lib/mailbox.php';
* Show a single message * Show a single message
* *
* // XXX: It is totally weird how this works! * // XXX: It is totally weird how this works!
* *
* @category Personal * @category Personal
* @package StatusNet * @package StatusNet
* @author Evan Prodromou <evan@status.net> * @author Evan Prodromou <evan@status.net>
* @license http://www.fsf.org/licensing/licenses/agpl-3.0.html GNU Affero General Public License version 3.0 * @license http://www.fsf.org/licensing/licenses/agpl-3.0.html GNU Affero General Public License version 3.0
* @link http://status.net/ * @link http://status.net/
*/ */
class ShowmessageAction extends MailboxAction class ShowmessageAction extends MailboxAction
{ {
/** /**
* Message object to show * Message object to show
*/ */
var $message = null; var $message = null;
/** /**
* The current user * The current user
*/ */
var $user = null; var $user = null;
/** /**
@ -67,17 +65,17 @@ class ShowmessageAction extends MailboxAction
* *
* @return success flag * @return success flag
*/ */
function prepare($args) function prepare($args)
{ {
parent::prepare($args); parent::prepare($args);
$this->page = 1; $this->page = 1;
$id = $this->trimmed('message'); $id = $this->trimmed('message');
$this->message = Message::staticGet('id', $id); $this->message = Message::staticGet('id', $id);
if (!$this->message) { if (!$this->message) {
// TRANS: Client error displayed requesting a single message that does not exist.
$this->clientError(_('No such message.'), 404); $this->clientError(_('No such message.'), 404);
return false; return false;
} }
@ -90,40 +88,47 @@ class ShowmessageAction extends MailboxAction
function handle($args) function handle($args)
{ {
Action::handle($args); Action::handle($args);
if ($this->user && ($this->user->id == $this->message->from_profile || if ($this->user && ($this->user->id == $this->message->from_profile ||
$this->user->id == $this->message->to_profile)) { $this->user->id == $this->message->to_profile)) {
$this->showPage(); $this->showPage();
} else { } else {
// TRANS: Client error displayed requesting a single direct message the requesting user was not a party in.
$this->clientError(_('Only the sender and recipient ' . $this->clientError(_('Only the sender and recipient ' .
'may read this message.'), 403); 'may read this message.'), 403);
return; return;
} }
} }
function title() function title()
{ {
if ($this->user->id == $this->message->from_profile) { if ($this->user->id == $this->message->from_profile) {
$to = $this->message->getTo(); $to = $this->message->getTo();
return sprintf(_("Message to %1\$s on %2\$s"), // @todo FIXME: Might be nice if the timestamp could be localised.
// TRANS: Page title for single direct message display when viewing user is the sender.
// TRANS: %1$s is the addressed user's nickname, $2$s is a timestamp.
return sprintf(_('Message to %1$s on %2$s'),
$to->nickname, $to->nickname,
common_exact_date($this->message->created)); common_exact_date($this->message->created));
} else if ($this->user->id == $this->message->to_profile) { } else if ($this->user->id == $this->message->to_profile) {
$from = $this->message->getFrom(); $from = $this->message->getFrom();
return sprintf(_("Message from %1\$s on %2\$s"), // @todo FIXME: Might be nice if the timestamp could be localised.
// TRANS: Page title for single message display.
// TRANS: %1$s is the sending user's nickname, $2$s is a timestamp.
return sprintf(_('Message from %1$s on %2$s'),
$from->nickname, $from->nickname,
common_exact_date($this->message->created)); common_exact_date($this->message->created));
} }
} }
function getMessages() function getMessages()
{ {
$message = new Message(); $message = new Message();
$message->id = $this->message->id; $message->id = $this->message->id;
$message->find(); $message->find();
return $message; return $message;
} }
function getMessageProfile() function getMessageProfile()
{ {
if ($this->user->id == $this->message->from_profile) { if ($this->user->id == $this->message->from_profile) {
@ -135,23 +140,21 @@ class ShowmessageAction extends MailboxAction
return null; return null;
} }
} }
/** /**
* Don't show local navigation * Don't show local navigation
* *
* @return void * @return void
*/ */
function showLocalNavBlock() function showLocalNavBlock()
{ {
} }
/** /**
* Don't show page notice * Don't show page notice
* *
* @return void * @return void
*/ */
function showPageNoticeBlock() function showPageNoticeBlock()
{ {
} }
@ -161,17 +164,15 @@ class ShowmessageAction extends MailboxAction
* *
* @return void * @return void
*/ */
function showAside()
function showAside()
{ {
} }
/** /**
* Don't show any instructions * Don't show any instructions
* *
* @return string * @return string
*/ */
function getInstructions() function getInstructions()
{ {
return ''; return '';

6
actions/subedit.php
View File

@ -19,6 +19,7 @@
if (!defined('STATUSNET') && !defined('LACONICA')) { exit(1); } if (!defined('STATUSNET') && !defined('LACONICA')) { exit(1); }
// @todo FIXME: Documentation needed.
class SubeditAction extends Action class SubeditAction extends Action
{ {
var $profile = null; var $profile = null;
@ -28,6 +29,7 @@ class SubeditAction extends Action
parent::prepare($args); parent::prepare($args);
if (!common_logged_in()) { if (!common_logged_in()) {
// TRANS: Client error displayed trying a change a subscription while not logged in.
$this->clientError(_('Not logged in.')); $this->clientError(_('Not logged in.'));
return false; return false;
} }
@ -43,6 +45,7 @@ class SubeditAction extends Action
$id = $this->trimmed('profile'); $id = $this->trimmed('profile');
if (!$id) { if (!$id) {
// TRANS: Client error displayed trying a change a subscription without providing a profile.
$this->clientError(_('No profile specified.')); $this->clientError(_('No profile specified.'));
return false; return false;
} }
@ -50,6 +53,7 @@ class SubeditAction extends Action
$this->profile = Profile::staticGet('id', $id); $this->profile = Profile::staticGet('id', $id);
if (!$this->profile) { if (!$this->profile) {
// TRANS: Client error displayed trying a change a subscription for a non-existant profile ID.
$this->clientError(_('No profile with that ID.')); $this->clientError(_('No profile with that ID.'));
return false; return false;
} }
@ -67,6 +71,7 @@ class SubeditAction extends Action
'subscribed' => $this->profile->id)); 'subscribed' => $this->profile->id));
if (!$sub) { if (!$sub) {
// TRANS: Client error displayed trying a change a subscription for a non-subscribed profile.
$this->clientError(_('You are not subscribed to that profile.')); $this->clientError(_('You are not subscribed to that profile.'));
return false; return false;
} }
@ -80,6 +85,7 @@ class SubeditAction extends Action
if (!$result) { if (!$result) {
common_log_db_error($sub, 'UPDATE', __FILE__); common_log_db_error($sub, 'UPDATE', __FILE__);
// TRANS: Server error displayed when updating a subscription fails with a database error.
$this->serverError(_('Could not save subscription.')); $this->serverError(_('Could not save subscription.'));
return false; return false;
} }