GNUsocial/gnu-social
4
0
Fork 1
Code Issues Releases Wiki Activity

[COMPONENT][Notification] We must record remote notifications because of feeds

Browse Source
This commit is contained in:
Diogo Peralta Cordeiro 2022-02-13 22:51:42 +00:00
parent 62bf788b90
commit 56c884026f
Signed by: diogo
GPG Key ID: 18D2D35001FBFAB0
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
components/Notification/Notification.php
View File

@ -85,14 +85,6 @@ class Notification extends Component
continue; continue;
} }
// TODO: use https://symfony.com/doc/current/notifier.html // TODO: use https://symfony.com/doc/current/notifier.html
// XXX: Unideal as in failures the rollback will leave behind a false notification,
// but most notifications (all) require flushing the objects first
// Should be okay as long as implementors bear this in mind
DB::wrapInTransaction(fn () => DB::persist(Entity\Notification::create([
'activity_id' => $activity->getId(),
'target_id' => $target->getId(),
'reason' => $reason,
])));
} }
} else { } else {
// We have no authority nor responsibility of notifying remote actors of a remote actor's doing // We have no authority nor responsibility of notifying remote actors of a remote actor's doing
@ -100,6 +92,14 @@ class Notification extends Component
$remote_targets[] = $target; $remote_targets[] = $target;
} }
} }
// XXX: Unideal as in failures the rollback will leave behind a false notification,
// but most notifications (all) require flushing the objects first
// Should be okay as long as implementors bear this in mind
DB::wrapInTransaction(fn () => DB::persist(Entity\Notification::create([
'activity_id' => $activity->getId(),
'target_id' => $target->getId(),
'reason' => $reason,
])));
} }
FreeNetwork::notify($sender, $activity, $remote_targets, $reason); FreeNetwork::notify($sender, $activity, $remote_targets, $reason);