From 60baacf80e1b2d8f475633210b5589ab7de048d3 Mon Sep 17 00:00:00 2001
From: Evan Prodromou <evan@controlyourself.ca>
Date: Tue, 23 Sep 2008 14:20:24 -0400
Subject: [PATCH] better logic around protecting messages

darcs-hash:20080923182024-5ed1f-cd751ae81cde929ab377734a41e0cdad321ffec5.gz
---
 actions/showmessage.php | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/actions/showmessage.php b/actions/showmessage.php
index ce4a1f3727..28e3594506 100644
--- a/actions/showmessage.php
+++ b/actions/showmessage.php
@@ -38,15 +38,12 @@ class ShowmessageAction extends MailboxAction {
 		
 		$cur = common_current_user();
 		
-		if (!$cur ||
-			$cur->id != $message->from_profile &&
-			$cur->id != $message->to_profile) 
-		{
+		if ($cur && ($cur->id == $message->from_profile || $cur->id == $message->to_profile)) {
+			$this->show_page($cur, 1);
+		} else {
 			$this->client_error(_('Only the sender and recipient may read this message.'), 403);
 			return;
 		}
-			
-		$this->show_page($cur, 1);
 	}
 	
 	function get_message() {