correct error-handling in newnotice

darcs-hash:20080521122604-84dde-bfcfe7b2a254f19ce56054f6e4c80317ed8aaf86.gz
This commit is contained in:
Evan Prodromou 2008-05-21 08:26:04 -04:00
parent 53eeee70e7
commit 659feb5f43
1 changed files with 5 additions and 2 deletions

View File

@ -42,6 +42,7 @@ class NewnoticeAction extends Action {
} }
function save_new_notice() { function save_new_notice() {
$user = common_current_user(); $user = common_current_user();
assert($user); # XXX: maybe an error instead... assert($user); # XXX: maybe an error instead...
$notice = DB_DataObject::factory('notice'); $notice = DB_DataObject::factory('notice');
@ -53,13 +54,15 @@ class NewnoticeAction extends Action {
if (!$notice->content) { if (!$notice->content) {
$this->show_form(_t('No content!')); $this->show_form(_t('No content!'));
return;
} else if (strlen($notice->content) > 140) { } else if (strlen($notice->content) > 140) {
$this->show_form(_t('Notice content too long.')); $this->show_form(_t('Notice content too long.'));
return;
} }
return $notice->insert(); return $notice->insert();
} }
function show_form($msg=NULL) { function show_form($msg=NULL) {
common_show_header(_t('New notice')); common_show_header(_t('New notice'));
if ($msg) { if ($msg) {