GNUsocial
/
gnu-social
4
0
Fork 1
Code Issues Releases Wiki Activity

add csrf protection to profile settings 

darcs-hash:20080829043909-84dde-c70a633c93ab89560bc300817bda66eebf6176cf.gz
This commit is contained in:
Evan Prodromou 2008-08-29 00:39:09 -04:00
parent 9a65f45c45
commit 6afb7f576e
1 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
actions/profilesettings.php
View File

@ -37,6 +37,7 @@ class ProfilesettingsAction extends SettingsAction {
'id' => 'profilesettings',
'action' =>
common_local_url('profilesettings')));
common_hidden('token', common_session_token());
# too much common patterns here... abstractable?
common_input('nickname', _('Nickname'),
($this->arg('nickname')) ? $this->arg('nickname') : $profile->nickname,
@ -80,6 +81,14 @@ class ProfilesettingsAction extends SettingsAction {
$language = $this->trimmed('language');
$timezone = $this->trimmed('timezone');
# CSRF protection
$token = $this->trimmed('token');
if (!$token || $token != common_session_token()) {
$this->show_form(_('There was a problem with your session token. Try again, please.'));
return;
}
# Some validation
if (!Validate::string($nickname, array('min_length' => 1,
@ -147,9 +156,9 @@ class ProfilesettingsAction extends SettingsAction {
}
# XXX: XOR
if ($user->autosubscribe ^ $autosubscribe) {
$original = clone($user);
$user->autosubscribe = $autosubscribe;
@ -162,7 +171,7 @@ class ProfilesettingsAction extends SettingsAction {
return;
}
}
$profile = $user->getProfile();
$orig_profile = clone($profile);