[DAEMONS] Properly disconnect daemons from the database

lib/util/daemon.php

@@ -1,68 +1,56 @@
 <?php
-/**
- * StatusNet - the distributed open-source microblogging tool
- * Copyright (C) 2008, 2009, StatusNet, Inc.
- *
- * This program is free software: you can redistribute it and/or modify
- * it under the terms of the GNU Affero General Public License as published by
- * the Free Software Foundation, either version 3 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU Affero General Public License for more details.
- *
- * You should have received a copy of the GNU Affero General Public License
- * along with this program.  If not, see <http://www.gnu.org/licenses/>.
- */
+// This file is part of GNU social - https://www.gnu.org/software/social
+//
+// GNU social is free software: you can redistribute it and/or modify
+// it under the terms of the GNU Affero General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// GNU social is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU Affero General Public License for more details.
+//
+// You should have received a copy of the GNU Affero General Public License
+// along with GNU social.  If not, see <http://www.gnu.org/licenses/>.
 
-if (!defined('STATUSNET') && !defined('LACONICA')) {
-    exit(1);
-}
+defined('GNUSOCIAL') || die();
 
 class Daemon
 {
-    var $daemonize = true;
-    var $_id = 'generic';
+    public $daemonize = true;
+    public $_id = 'generic';
 
-    function __construct($daemonize = true)
+    public function __construct($daemonize = true)
     {
         $this->daemonize = $daemonize;
     }
 
-    function name()
+    public function name()
     {
         return null;
     }
 
-    function get_id()
+    public function get_id()
     {
         return $this->_id;
     }
 
-    function set_id($id)
+    public function set_id($id)
     {
         $this->_id = $id;
     }
 
-    function background()
+    public function background()
     {
-        /*
-         * This prefers to Starting PHP 5.4 (dotdeb), maybe earlier for some version/distrib
-         * seems MySQL connection using mysqli driver get lost when fork.
-         * Need to unset it so that child process recreate it.
-         *
-         * @todo FIXME cleaner way to do it ?
-         */
-        global $_DB_DATAOBJECT;
-        unset($_DB_DATAOBJECT['CONNECTIONS']);
+        // Database connection will likely get lost after forking
+        $this->resetDb();
 
         $pid = pcntl_fork();
         if ($pid < 0) { // error
             common_log(LOG_ERR, "Could not fork.");
             return false;
-        } else if ($pid > 0) { // parent
+        } elseif ($pid > 0) { // parent
             common_log(LOG_INFO, "Successfully forked.");
             exit(0);
         } else { // child
@@ -70,7 +58,7 @@ class Daemon
         }
     }
 
-    function alreadyRunning()
+    public function alreadyRunning()
     {
         $pidfilename = $this->pidFilename();
 
@@ -89,7 +77,7 @@ class Daemon
         }
     }
 
-    function writePidFile()
+    public function writePidFile()
     {
         $pidfilename = $this->pidFilename();
 
@@ -100,7 +88,7 @@ class Daemon
         return file_put_contents($pidfilename, posix_getpid() . "\n");
     }
 
-    function clearPidFile()
+    public function clearPidFile()
     {
         $pidfilename = $this->pidFilename();
         if (!$pidfilename) {
@@ -109,7 +97,7 @@ class Daemon
         return unlink($pidfilename);
     }
 
-    function pidFilename()
+    public function pidFilename()
     {
         $piddir = common_config('daemon', 'piddir');
         if (!$piddir) {
@@ -122,15 +110,17 @@ class Daemon
         return $piddir . '/' . $name . '.pid';
     }
 
-    function changeUser()
+    public function changeUser()
     {
         $groupname = common_config('daemon', 'group');
 
         if ($groupname) {
             $group_info = posix_getgrnam($groupname);
             if (!$group_info) {
-                common_log(LOG_WARNING,
-                           'Ignoring unknown group for daemon: ' . $groupname);
+                common_log(
+                    LOG_WARNING,
+                    'Ignoring unknown group for daemon: ' . $groupname
+                );
             } else {
                 common_log(LOG_INFO, "Setting group to " . $groupname);
                 posix_setgid($group_info['gid']);
@@ -142,8 +132,10 @@ class Daemon
         if ($username) {
             $user_info = posix_getpwnam($username);
             if (!$user_info) {
-                common_log(LOG_WARNING,
-                           'Ignoring unknown user for daemon: ' . $username);
+                common_log(
+                    LOG_WARNING,
+                    'Ignoring unknown user for daemon: ' . $username
+                );
             } else {
                 common_log(LOG_INFO, "Setting user to " . $username);
                 posix_setuid($user_info['uid']);
@@ -151,7 +143,7 @@ class Daemon
         }
     }
 
-    function runOnce()
+    public function runOnce()
     {
         if ($this->alreadyRunning()) {
             common_log(LOG_INFO, $this->name() . ' already running. Exiting.');
@@ -169,7 +161,7 @@ class Daemon
         $this->clearPidFile();
     }
 
-    function run()
+    public function run()
     {
         return true;
     }