GNUsocial
/
gnu-social
4
0
Fork 1
Code Issues Releases Wiki Activity

Merge branch 'improve-status-length-calculation' into 'master' 

improve status length calculation for messages forwarded to Twitter

See merge request !133
This commit is contained in:
mmn 2017-01-15 20:23:41 +00:00
parent 7d67eefdf5 f198d5d110
commit 7dcb229ab3
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
plugins/TwitterBridge/twitter.php
View File

@ -81,7 +81,7 @@ function save_twitter_user($twitter_id, $screen_name)
} }
} catch (NoResultException $e) { } catch (NoResultException $e) {
// No old users exist for this id // No old users exist for this id
// Kill any old, invalid records for this screen name // Kill any old, invalid records for this screen name
// XXX: Is this really only supposed to be run if the above getForeignUser fails? // XXX: Is this really only supposed to be run if the above getForeignUser fails?
try { try {
@ -389,11 +389,16 @@ function format_status($notice)
// XXX: Make this an optional setting? // XXX: Make this an optional setting?
$statustxt = preg_replace('/(^|\s)!([A-Za-z0-9]{1,64})/', "\\1#\\2", $statustxt); $statustxt = preg_replace('/(^|\s)!([A-Za-z0-9]{1,64})/', "\\1#\\2", $statustxt);
// detect links, each link uses 23 characters on twitter
$numberOfLinks = preg_match_all('`((http|https|ftp)://[^\s<]+[^\s<\.)])`i', $statustxt);
$statusWithoutLinks = preg_replace('`((http|https|ftp)://[^\s<]+[^\s<\.)])`i', '', $statustxt);
$statusLength = mb_strlen($statusWithoutLinks) + $numberOfLinks * 23;
// Twitter still has a 140-char hardcoded max. // Twitter still has a 140-char hardcoded max.
if (mb_strlen($statustxt) > 140) { if ($statusLength > 140) {
$noticeUrl = common_shorten_url($notice->getUrl()); $noticeUrl = common_shorten_url($notice->getUrl());
$urlLen = mb_strlen($noticeUrl); // each link uses 23 chars on twitter + 3 for the ' … ' => 26
$statustxt = mb_substr($statustxt, 0, 140 - ($urlLen + 3)) . ' … ' . $noticeUrl; $statustxt = mb_substr($statustxt, 0, 140 - 26) . ' … ' . $noticeUrl;
} }
return $statustxt; return $statustxt;