From 89e84e9b1bf1d7d95aa5d78522d536247df295d8 Mon Sep 17 00:00:00 2001 From: Alexei Sorokin Date: Mon, 6 Jul 2020 19:20:44 +0300 Subject: [PATCH] [NOTICES] Revert "We want the profile stream to be as raw as possible!" There are only three possible visible notice verbs: POST, SHARE and DELETE. What including all verbs does is it makes limiting (FETCH FIRST) unreliable as the query will fetch invisible stuff (like favourites) and count it in, but nothing will be displayed. NoticeStream only allows POST and SHARE, so this effectively removes tombstones from the profile page like in 78a111b57d96721b2136b7d9e0da515f8382f224 --- lib/{profile => notices}/profilenoticestream.php | 1 - 1 file changed, 1 deletion(-) rename lib/{profile => notices}/profilenoticestream.php (98%) diff --git a/lib/profile/profilenoticestream.php b/lib/notices/profilenoticestream.php similarity index 98% rename from lib/profile/profilenoticestream.php rename to lib/notices/profilenoticestream.php index 5100293e51..d1e6a7c8dd 100644 --- a/lib/profile/profilenoticestream.php +++ b/lib/notices/profilenoticestream.php @@ -107,7 +107,6 @@ class ProfileNoticeStream extends ScopingNoticeStream class RawProfileNoticeStream extends NoticeStream { protected $target; - protected $selectVerbs = array(); // select all verbs public function __construct(Profile $target) {