GNUsocial/gnu-social
4
0
Fork 1
Code Issues Releases Wiki Activity

[COMPONENT][Notification] Do not re-render content just to grab attentions

Browse Source 
Other minor improvements and bug fixes
This commit is contained in:
Diogo Peralta Cordeiro
2021-12-21 16:04:50 +00:00
parent e2c0505620
commit 8b5286c383
3 changed files with 66 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/Entity/Activity.php
View File

@@ -154,10 +154,11 @@ class Activity extends Entity
}
/**
* Who should be notified about this object?
*
* @return array of Actors
* @return array of ids of Actors
*/
public function getNotificationTargets(array $ids_already_known = [], ?int $sender_id = null): array
public function getNotificationTargetIds(array $ids_already_known = [], ?int $sender_id = null): array
{
$target_ids = [];
@@ -182,7 +183,7 @@ class Activity extends Entity
if (!is_null($author = $this->getObject()?->getActorId()) && $author !== $sender_id) {
$target_ids[] = $this->getObject()->getActorId();
}
array_push($target_ids, ...$this->getObject()->getNotificationTargets($ids_already_known));
array_push($target_ids, ...$this->getObject()->getNotificationTargetIds($ids_already_known));
}
// Additional actors that should know about this
@@ -190,8 +191,7 @@ class Activity extends Entity
array_push($target_ids, ...$ids_already_known['additional']);
}
$target_ids = array_unique($target_ids);
return $target_ids === [] ? [] : DB::findBy('actor', ['id' => $target_ids]);
return array_unique($target_ids);
}
public static function schemaDef(): array