GNUsocial/gnu-social
4
0
Fork 1
Code Issues Releases Wiki Activity

I like to throw exceptions instead of using if statements.

Browse Source
This commit is contained in:
Mikael Nordfeldth 2017-05-02 09:07:39 +02:00
parent 06b25f384a
commit 979c525124
2 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
classes/File.php
View File

@ -194,10 +194,14 @@ class File extends Managed_DataObject
} }
$redir = File_redirection::where($given_url); $redir = File_redirection::where($given_url);
$file = $redir->getFile(); try {
$file = $redir->getFile();
if (!$file instanceof File || empty($file->id)) { } catch (EmptyPkeyValueException $e) {
common_log(LOG_ERR, 'File_redirection::where gave object with empty file_id for given_url '._ve($given_url));
throw new ServerException('URL processing failed without new File object');
} catch (NoResultException $e) {
// This should not happen // This should not happen
common_log(LOG_ERR, 'File_redirection after discovery could still not return a File object.');
throw new ServerException('URL processing failed without new File object'); throw new ServerException('URL processing failed without new File object');
} }

4
classes/File_redirection.php
View File

@ -445,8 +445,8 @@ class File_redirection extends Managed_DataObject
} }
public function getFile() { public function getFile() {
if(empty($this->file) && $this->file_id) { if (!$this->file instanceof File) {
$this->file = File::getKV('id', $this->file_id); $this->file = File::getByID($this->file_id);
} }
return $this->file; return $this->file;