From 9811783f19c09f674a5dbc3869fe71da8d53594b Mon Sep 17 00:00:00 2001 From: Mikael Nordfeldth Date: Sun, 20 Oct 2013 17:15:46 +0200 Subject: [PATCH] Strict type check against false in User_group --- classes/User_group.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/classes/User_group.php b/classes/User_group.php index 5cae07bf29..bbae402091 100644 --- a/classes/User_group.php +++ b/classes/User_group.php @@ -630,7 +630,7 @@ class User_group extends Managed_DataObject $profile->query('BEGIN'); $id = $profile->insert(); - if (empty($id)) { + if ($id === false) { $profile->query('ROLLBACK'); throw new ServerException(_('Profile insertion failed')); } @@ -654,7 +654,7 @@ class User_group extends Managed_DataObject $result = $group->insert(); - if (!$result) { + if ($result === false) { common_log_db_error($group, 'INSERT', __FILE__); // TRANS: Server exception thrown when creating a group failed. throw new ServerException(_('Could not create group.'));