From e3c5d1664f8049b85198cf5c43957a237cb29bcf Mon Sep 17 00:00:00 2001 From: Zach Copley Date: Wed, 24 Jun 2009 16:10:28 -0700 Subject: [PATCH 1/3] Take out noisy debugging statement --- actions/twitapistatuses.php | 2 -- 1 file changed, 2 deletions(-) diff --git a/actions/twitapistatuses.php b/actions/twitapistatuses.php index e1fbc5c767..555c746cbc 100644 --- a/actions/twitapistatuses.php +++ b/actions/twitapistatuses.php @@ -78,8 +78,6 @@ class TwitapistatusesAction extends TwitterapiAction $this->auth_user = $apidata['user']; $user = $this->get_user($apidata['api_arg'], $apidata); - common_debug("auth user = " . $this->auth_user->nickname); - if (empty($user)) { $this->clientError(_('No such user!'), 404, $apidata['content-type']); From fa57e717e3bbb01e0c19fcb30f3d67bd596c730f Mon Sep 17 00:00:00 2001 From: Sarven Capadisli Date: Thu, 25 Jun 2009 00:25:22 +0000 Subject: [PATCH 2/3] Moved the attachment representation outside of the anchor so that onclick, it doesn't follow through on the href (e.g., it would play the video in the overlay instead) --- lib/attachmentlist.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/attachmentlist.php b/lib/attachmentlist.php index a2446a886a..60f9a27c0a 100644 --- a/lib/attachmentlist.php +++ b/lib/attachmentlist.php @@ -249,8 +249,8 @@ class Attachment extends AttachmentListItem $this->out->elementStart('div', 'entry-title'); $this->out->elementStart('a', $this->linkAttr()); $this->out->element('span', null, $this->linkTitle()); - $this->showRepresentation(); $this->out->elementEnd('a'); + $this->showRepresentation(); $this->out->elementEnd('div'); if (!empty($this->oembed->author_name) || !empty($this->oembed->provider)) { From 835799ff169387e5b686b2740020dc0e49154bb2 Mon Sep 17 00:00:00 2001 From: Sarven Capadisli Date: Thu, 25 Jun 2009 00:49:54 +0000 Subject: [PATCH 3/3] Separated attachment view components --- lib/attachmentlist.php | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/attachmentlist.php b/lib/attachmentlist.php index 60f9a27c0a..b5513ade7d 100644 --- a/lib/attachmentlist.php +++ b/lib/attachmentlist.php @@ -250,6 +250,9 @@ class Attachment extends AttachmentListItem $this->out->elementStart('a', $this->linkAttr()); $this->out->element('span', null, $this->linkTitle()); $this->out->elementEnd('a'); + $this->out->elementEnd('div'); + + $this->out->elementStart('div', 'entry-content'); $this->showRepresentation(); $this->out->elementEnd('div');