GNUsocial/gnu-social
4
0
Fork 1
Code Issues Releases Wiki Activity

Tweak DB query logging to also log queries that fail; the exceptions we get are often not very descriptive like "No such table" without saying which table. :)

Browse Source
This commit is contained in:
Brion Vibber
2010-10-15 11:26:06 -07:00
parent 0721d8d3e2
commit a7d98435f6
1 changed files with 16 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
classes/Memcached_DataObject.php
View File

@@ -338,13 +338,27 @@ class Memcached_DataObject extends Safe_DataObject
} }
$start = microtime(true); $start = microtime(true);
$fail = false;
try {
$result = parent::_query($string); $result = parent::_query($string);
} catch (Exception $e) {
$fail = $e;
}
$delta = microtime(true) - $start; $delta = microtime(true) - $start;
$limit = common_config('db', 'log_slow_queries'); $limit = common_config('db', 'log_slow_queries');
if (($limit > 0 && $delta >= $limit) || common_config('db', 'log_queries')) { if (($limit > 0 && $delta >= $limit) || common_config('db', 'log_queries')) {
$clean = $this->sanitizeQuery($string); $clean = $this->sanitizeQuery($string);
common_log(LOG_DEBUG, sprintf("DB query (%0.3fs): %s", $delta, $clean)); if ($fail) {
$msg = sprintf("FAILED DB query (%0.3fs): %s - %s", $delta, $fail->getMessage(), $clean);
} else {
$msg = sprintf("DB query (%0.3fs): %s", $delta, $clean);
}
common_log(LOG_DEBUG, $msg);
}
if ($fail) {
throw $fail;
} }
return $result; return $result;
} }