GNUsocial
/
gnu-social
4
0
Fork 1
Code Issues Releases Wiki Activity

Fix regression in OMB sending with queues enabled -- items never got dequeued, leading to ever-growing queue and big delays. 

Success return code from omb_broadcast_message was dropped in commit ec88d2650e (Aug 10 2009) which switched us to libomb backend. With queues enabled, this would lead to the notice being readded to the outgoing OMB queue for redelivery as the queue system thought the send failed. The resends caused extra load and confusion for third-party sites, and more worryingly just plugged up our own queue so legit messages were badly delayed.

This commit should restore the previous state, where we fire-and-forget; that is, we're not actually checking to see if all remote subscribers received the message successfully and there will be no resends.
This commit is contained in:
Brion Vibber 2009-11-24 15:29:47 -08:00
parent e0ae89867b
commit a9bbfd1852
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/omb.php
View File

@ -102,7 +102,7 @@ function omb_broadcast_notice($notice)
common_debug('Finished to ' . $rp->postnoticeurl, __FILE__);
}
return;
return true;
}
function omb_broadcast_profile($profile)