[Favorite] Fix "Properly trigger DisfavorNotice on profile deletion"

Calling find() inside delete() is probably not a good idea.
This commit is contained in:
Alexei Sorokin
2020-08-04 13:23:31 +03:00
parent a9c365a5eb
commit ab4120721f
2 changed files with 14 additions and 11 deletions

View File

@@ -342,7 +342,14 @@ class FavoriteModule extends ActivityVerbHandlerModule
{
$fave = new Fave();
$fave->user_id = $profile->id;
$fave->delete(); // Will perform a DELETE matching "user_id = {$user->id}"
// Will perform a DELETE matching "user_id = {$user->id}"
if ($fave->find()) {
while ($fave->fetch()) {
$fave->delete();
}
}
$fave->free();
Fave::blowCacheForProfileId($profile->id);