GNUsocial/gnu-social
4
0
Fork 1
Code Issues Releases Wiki Activity

[TOOLS] Fix all errors found by PHPStan level 1

Browse Source
This commit is contained in:
Hugo Sales
2021-09-06 20:59:36 +01:00
parent 0da6ff05ed
commit add8f4a52f
19 changed files with 83 additions and 54 deletions
Download Patch File Download Diff File Expand all files Collapse all files

44
plugins/Favourite/Favourite.php
View File

@@ -77,28 +77,32 @@ class Favourite extends NoteHandlerPlugin
// Form handler
$ret = self::noteActionHandle(
$request, $form_fav, $note, "favourite-{$note->getId()}", /**
* Called from form handler
*
* @param $note Note to be favourited
* @param $data Form input
*
* @throws RedirectException Always thrown in order to prevent accidental form re-submit from browser
*/ function ($note, $data) use ($opts, $request) {
$favourite_note = DB::find('favourite', $opts);
if ($data["favourite-{$note->getId()}"] === '0' && $favourite_note === null) {
DB::persist(Entity\Favourite::create($opts));
DB::flush();
} else if ($data["favourite-{$note->getId()}"] === '1' && $favourite_note !== null) {
DB::remove($favourite_note);
DB::flush();
}
$request, $form_fav, $note, "favourite-{$note->getId()}",
/**
* Called from form handler
*
* @param $note Note to be favourited
* @param $data Form input
*
* @throws RedirectException Always thrown in order to prevent accidental form re-submit from browser
*/
function ($note, $data) use ($opts) {
$favourite_note = DB::find('favourite', $opts);
if ($data["favourite-{$note->getId()}"] === '0' && $favourite_note === null) {
DB::persist(Entity\Favourite::create($opts));
DB::flush();
} else {
if ($data["favourite-{$note->getId()}"] === '1' && $favourite_note !== null) {
DB::remove($favourite_note);
DB::flush();
}
}
// Prevent accidental refreshes from resubmitting the form
throw new RedirectException();
// Prevent accidental refreshes from resubmitting the form
throw new RedirectException();
return Event::stop;
});
return Event::stop;
});
if ($ret !== null) {
return $ret;