explicitly skip nulls in Memcached_DataObject::multiGet()

This commit is contained in:
Evan Prodromou 2011-07-14 14:41:30 -04:00
parent dc7099aa5a
commit ae340ec345
2 changed files with 39 additions and 4 deletions

View File

@ -64,7 +64,17 @@ class Memcached_DataObject extends Safe_DataObject
return $i; return $i;
} }
function multiGet($cls, $keyCol, $keyVals) /**
* Get multiple items from the database by key
*
* @param string $cls Class to fetch
* @param string $keyCol name of column for key
* @param array $keyVals key values to fetch
* @param boolean $skipNulls return only non-null results?
*
* @return array Array of objects, in order
*/
function multiGet($cls, $keyCol, $keyVals, $skipNulls=true)
{ {
$result = array_fill_keys($keyVals, null); $result = array_fill_keys($keyVals, null);
@ -92,9 +102,34 @@ class Memcached_DataObject extends Safe_DataObject
$result[$i->$keyCol] = $copy; $result[$i->$keyCol] = $copy;
} }
} }
// Save state of DB misses
foreach ($toFetch as $keyVal) {
if (empty($result[$keyVal])) {
// save the fact that no such row exists
$c = self::memcache();
if (!empty($c)) {
$ck = self::cachekey($cls, $keyCol, $keyVal);
$c->set($ck, null);
}
}
}
} }
return new ArrayWrapper(array_values($result)); $values = array_values($result);
if ($skipNulls) {
$tmp = array();
foreach ($values as $value) {
if (!empty($value)) {
$tmp[] = $value;
}
}
$values = $tmp;
}
return new ArrayWrapper($values);
} }
function columnType($columnName) function columnType($columnName)

View File

@ -84,9 +84,9 @@ class Notice extends Memcached_DataObject
/* the code above is auto generated do not remove the tag below */ /* the code above is auto generated do not remove the tag below */
###END_AUTOCODE ###END_AUTOCODE
function multiGet($kc, $kvs) function multiGet($kc, $kvs, $skipNulls=true)
{ {
return Memcached_DataObject::multiGet('Notice', $kc, $kvs); return Memcached_DataObject::multiGet('Notice', $kc, $kvs, $skipNulls);
} }
/* Notice types */ /* Notice types */