From ab7a06542c73b6bcd903d0184bd1cf4ac494c560 Mon Sep 17 00:00:00 2001 From: Brion Vibber Date: Fri, 10 Dec 2010 22:08:36 +0000 Subject: [PATCH] Workaround for locally-handled sessions breaking on PHP 5.3 with APC enabled. Big thanks to the folks at http://pecl.php.net/bugs/bug.php?id=16745 for the secret juju! Classes were being torn down before session save handlers got called at the end of the request, which exploded with complaints about being unable to find various classes. Registering a shutdown function lets us explicitly close out the session before everything gets torn down. --- classes/Session.php | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/classes/Session.php b/classes/Session.php index 2422f8b68e..e1c83ad4dc 100644 --- a/classes/Session.php +++ b/classes/Session.php @@ -178,6 +178,18 @@ class Session extends Memcached_DataObject $result = session_set_save_handler('Session::open', 'Session::close', 'Session::read', 'Session::write', 'Session::destroy', 'Session::gc'); self::logdeb("save handlers result = $result"); + + // PHP 5.3 with APC ends up destroying a bunch of object stuff before the session + // save handlers get called on request teardown. + // Registering an explicit shutdown function should take care of this before + // everything breaks on us. + register_shutdown_function('Session::cleanup'); + return $result; } + + static function cleanup() + { + session_write_close(); + } }