From b4a03b814f44a01e21e430dc7bcd6262d117f82c Mon Sep 17 00:00:00 2001
From: Diogo Peralta Cordeiro <mail@diogo.site>
Date: Sat, 14 Aug 2021 15:05:56 +0100
Subject: [PATCH] [CORE][GSFile] ensureFilenameWithProperExtension: extension
 isn't an I/O param

---
 src/Core/GSFile.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/Core/GSFile.php b/src/Core/GSFile.php
index 9ae0d1f57c..5fa67ae4d8 100644
--- a/src/Core/GSFile.php
+++ b/src/Core/GSFile.php
@@ -231,9 +231,9 @@ class GSFile
      * @param null|string $ext      Extension we believe to be best
      * @param bool        $force    Should we force the extension we believe to be best? Defaults to false
      *
-     * @return null|string
+     * @return null|string the most appropriate filename or null if we deem it imposible
      */
-    public static function ensureFilenameWithProperExtension(string $title, string $mimetype, ?string &$ext = null, bool $force = false): string | null
+    public static function ensureFilenameWithProperExtension(string $title, string $mimetype, ?string $ext = null, bool $force = false): string | null
     {
         $valid_extensions = MimeTypes::getDefault()->getExtensions($mimetype);