GNUsocial/gnu-social
4
0
Fork 1
Code Issues Releases Wiki Activity

[TOOLS] Continue raising PHPStan to level 6

Browse Source
This commit is contained in:
Hugo Sales
2022-10-19 22:39:17 +01:00
parent e6bb418fe6
commit c31f3d4997
25 changed files with 233 additions and 58 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
components/Circle/Controller/Circles.php
View File

@@ -31,16 +31,20 @@ use App\Entity\LocalUser;
use Component\Circle\Entity\ActorCircle;
use Component\Collection\Util\Controller\MetaCollectionController;
/**
* @extends MetaCollectionController<Circles>
*/
class Circles extends MetaCollectionController
{
protected const SLUG = 'circle';
protected const PLURAL_SLUG = 'circles';
protected string $page_title = 'Actor circles';
public function createCollection(int $owner_id, string $name)
public function createCollection(int $owner_id, string $name): bool
{
return \Component\Circle\Circle::createCircle($owner_id, $name);
return !\is_null(\Component\Circle\Circle::createCircle($owner_id, $name));
}
public function getCollectionUrl(int $owner_id, ?string $owner_nickname, int $collection_id): string
{
return Router::url(
@@ -49,21 +53,26 @@ class Circles extends MetaCollectionController
);
}
public function getCollectionItems(int $owner_id, $collection_id): array
/**
* @return Circles[]
*/
public function getCollectionItems(int $owner_id, int $collection_id): array
{
$notes = []; // TODO: Use Feed::query
return [
'_template' => 'collection/notes.html.twig',
'notes' => $notes,
];
return []; // TODO
}
/**
* @return Circles[]
*/
public function feedByCircleId(int $circle_id)
{
// Owner id isn't used
return $this->getCollectionItems(0, $circle_id);
}
/**
* @return Circles[]
*/
public function feedByTaggerIdAndTag(int $tagger_id, string $tag)
{
// Owner id isn't used
@@ -71,6 +80,9 @@ class Circles extends MetaCollectionController
return $this->getCollectionItems($tagger_id, $circle_id);
}
/**
* @return Circles[]
*/
public function feedByTaggerNicknameAndTag(string $tagger_nickname, string $tag)
{
$tagger_id = LocalUser::getByNickname($tagger_nickname)->getId();
@@ -78,6 +90,9 @@ class Circles extends MetaCollectionController
return $this->getCollectionItems($tagger_id, $circle_id);
}
/**
* @return ActorCircle[]
*/
public function getCollectionsByActorId(int $owner_id): array
{
return DB::findBy(ActorCircle::class, ['tagger' => $owner_id], order_by: ['id' => 'desc']);
@@ -87,7 +102,7 @@ class Circles extends MetaCollectionController
return DB::findOneBy(ActorCircle::class, ['id' => $collection_id, 'actor_id' => $owner_id]);
}
public function setCollectionName(int $actor_id, string $actor_nickname, ActorCircle $collection, string $name)
public function setCollectionName(int $actor_id, string $actor_nickname, ActorCircle $collection, string $name): void
{
foreach ($collection->getActorTags(db_reference: true) as $at) {
$at->setTag($name);
@@ -96,7 +111,7 @@ class Circles extends MetaCollectionController
Cache::delete(Actor::cacheKeys($actor_id)['circles']);
}
public function removeCollection(int $actor_id, string $actor_nickname, ActorCircle $collection)
public function removeCollection(int $actor_id, string $actor_nickname, ActorCircle $collection): void
{
foreach ($collection->getActorTags(db_reference: true) as $at) {
DB::remove($at);