GNUsocial/gnu-social
4
0
Fork 1
Code Issues Releases Wiki Activity

Oembed bugs with thumbnail generation.

Browse Source
This commit is contained in:
Mikael Nordfeldth 2016-04-18 15:33:20 +02:00
parent 5ccf3ed714
commit ce65fe96ad
1 changed files with 19 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
plugins/Oembed/actions/oembed.php
View File

@ -84,26 +84,25 @@ class OembedAction extends Action
$oembed['html']=$notice->getRendered(); $oembed['html']=$notice->getRendered();
// maybe add thumbnail // maybe add thumbnail
$attachments = $notice->attachments(); foreach ($notice->attachments() as $attachment) {
if (!empty($attachments)) { if (!$attachment instanceof File) {
foreach ($attachments as $attachment) { common_debug('ATTACHMENTS array entry from notice id=='._ve($notice->getID()).' is something else than a File dataobject: '._ve($attachment));
if(is_object($attachment)) { continue;
try {
$thumb = $attachment->getThumbnail();
} catch (ServerException $e) {
//
} }
try { try {
$thumb = $attachment->getThumbnail();
$thumb_url = File_thumbnail::url($thumb->filename); $thumb_url = File_thumbnail::url($thumb->filename);
$oembed['thumbnail_url'] = $thumb_url; $oembed['thumbnail_url'] = $thumb_url;
break; // only first one break; // only first one
} catch (UseFileAsThumbnailException $e) {
$oembed['thumbnail_url'] = $attachment->getUrl();
break; // we're happy with that
} catch (ServerException $e) {
//
} catch (ClientException $e) { } catch (ClientException $e) {
// //
} }
} }
}
}
break; break;
case 'attachment': case 'attachment':