[AttachmentToNote][Attachment] Add title getter to Attachment

plugins/VideoEncoder/VideoEncoder.php

@@ -78,7 +78,11 @@ class VideoEncoder extends Plugin
      */
     public function onViewAttachmentVideo(array $vars, array &$res): bool
     {
-        $res[] = Formatting::twigRenderFile('videoEncoder/videoEncoderView.html.twig', ['attachment' => $vars['attachment'], 'thumbnail_parameters' => $vars['thumbnail_parameters']]);
+        $res[] = Formatting::twigRenderFile('videoEncoder/videoEncoderView.html.twig',
+        ['attachment'              => $vars['attachment'],
+            'thumbnail_parameters' => $vars['thumbnail_parameters'],
+            'note'                 => $vars['note'],
+        ]);
         return Event::stop;
     }
 

plugins/VideoEncoder/templates/videoEncoder/videoEncoderView.html.twig

@@ -3,7 +3,7 @@
         <video class="u-video" src="{{ path('attachment_view', {'id': attachment.getId()}) }}" controls poster="{{ path('attachment_thumbnail', thumbnail_parameters) }}">
         </video>
         <figcaption><a
-                href="{{ path('attachment_show', {'id': attachment.getId()}) }}">{{ attachment.getFilename() }}</a>
+                href="{{ path('attachment_show', {'id': attachment.getId()}) }}">{{ attachment.getBestTitle(note) }}</a>
         </figcaption>
     </figure>
 </div>