GNUsocial/gnu-social
4
0
Fork 1
Code Issues Releases Wiki Activity

Format timestamps as UTC in ActivityStreams output. While using local times is legit per spec, it's confusing to have it change around and confuses some clients that don't handle zones right.

Browse Source
This commit is contained in:
Brion Vibber 2011-03-30 12:36:54 -07:00
parent d2cd5b3353
commit da7c54023d
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
lib/activity.php
View File

@ -704,11 +704,18 @@ class Activity
return ActivityUtils::child($element, $tag, $namespace); return ActivityUtils::child($element, $tag, $namespace);
} }
/**
* For consistency, we'll always output UTC rather than local time.
* Note that clients *should* accept any timezone we give them as long
* as it's properly formatted.
*
* @param int $tm Unix timestamp
* @return string
*/
static function iso8601Date($tm) static function iso8601Date($tm)
{ {
$dateStr = date('d F Y H:i:s', $tm); $dateStr = date('d F Y H:i:s', $tm);
$d = new DateTime($dateStr, new DateTimeZone('UTC')); $d = new DateTime($dateStr, new DateTimeZone('UTC'));
$d->setTimezone(new DateTimeZone(common_timezone()));
return $d->format('c'); return $d->format('c');
} }
} }