From df84ccd916ec6a0458fbe7432d388438e967af98 Mon Sep 17 00:00:00 2001
From: Diogo Cordeiro <diogo@fc.up.pt>
Date: Mon, 3 Jun 2019 02:39:39 +0100
Subject: [PATCH] Nodeinfo has a special rule for upgrades

---
 plugins/Nodeinfo/NodeinfoPlugin.php    |  9 +++++++
 plugins/Nodeinfo/scripts/fix_stats.php | 34 ++++++++++++++++----------
 2 files changed, 30 insertions(+), 13 deletions(-)

diff --git a/plugins/Nodeinfo/NodeinfoPlugin.php b/plugins/Nodeinfo/NodeinfoPlugin.php
index 8fe6a7999a..79defe39fd 100644
--- a/plugins/Nodeinfo/NodeinfoPlugin.php
+++ b/plugins/Nodeinfo/NodeinfoPlugin.php
@@ -176,4 +176,13 @@ class NodeinfoPlugin extends Plugin
             'description' => _m('Plugin that presents basic instance information using the NodeInfo standard.')];
         return true;
     }
+
+    public function onEndUpgrade()
+    {
+        $users = new Usage_stats();
+        if ($users->getUserCount() == 0) {
+            define('NODEINFO_UPGRADE', true);
+            require_once __DIR__ . DIRECTORY_SEPARATOR . 'scripts' . DIRECTORY_SEPARATOR . 'fix_stats.php';
+        }
+    }
 }
diff --git a/plugins/Nodeinfo/scripts/fix_stats.php b/plugins/Nodeinfo/scripts/fix_stats.php
index e94c2bee50..a34e24f827 100755
--- a/plugins/Nodeinfo/scripts/fix_stats.php
+++ b/plugins/Nodeinfo/scripts/fix_stats.php
@@ -25,9 +25,11 @@
 
 define('INSTALLDIR', realpath(__DIR__ . '/../../..'));
 
-$longoptions = ['type='];
+if (!defined('NODEINFO_UPGRADE')) {
 
-$helptext = <<<END_OF_HELP
+    $longoptions = ['type='];
+
+    $helptext = <<<END_OF_HELP
 fix_stats.php [options]
 Counts the stats from database values and updates the table.
 
@@ -35,21 +37,27 @@ Counts the stats from database values and updates the table.
 
 END_OF_HELP;
 
-require_once INSTALLDIR . '/scripts/commandline.inc';
+    require_once INSTALLDIR . '/scripts/commandline.inc';
 
-$valid_types = ['all', 'users', 'posts', 'comments'];
+    $valid_types = ['all', 'users', 'posts', 'comments'];
 
-$verbose = have_option('v', 'verbose');
+    $verbose = have_option('v', 'verbose');
 
-$type_to_fix = get_option_value('type');
-if (!in_array($type_to_fix, $valid_types)) {
-    echo "You must provide a valid type!\n\n";
-    show_help();
-    exit(1);
-}
+    $type_to_fix = get_option_value('type');
+    if (!in_array($type_to_fix, $valid_types)) {
+        echo "You must provide a valid type!\n\n";
+        show_help();
+        exit(1);
+    }
 
-if ($verbose) {
-    echo "Started.\n\n";
+    if ($verbose) {
+        echo "Started.\n\n";
+    }
+
+} else {
+    echo "Nodeinfo will now fix stats\n";
+    $type_to_fix = 'all';
+    $verbose = true;
 }
 
 if ($type_to_fix == 'all' || $type_to_fix == 'users') {