From e0438b8223e7bb37e812e25bea502e31013333e5 Mon Sep 17 00:00:00 2001
From: Evan Prodromou <evan@prodromou.name>
Date: Sat, 17 May 2008 09:51:38 -0400
Subject: [PATCH] bogus version of common_local_url()

Threw together a bogus version of common_local_url(), which should
work for now. But eventually it should use pretty URLs if possible.

darcs-hash:20080517135138-84dde-3c69c89ee8080568e92f655cbb3171867a7b38ce.gz
---
 doc/TODO       |  9 ++++++++-
 lib/common.php | 13 +++++++++++++
 2 files changed, 21 insertions(+), 1 deletion(-)

diff --git a/doc/TODO b/doc/TODO
index 08df348e2f..1eaad981a1 100644
--- a/doc/TODO
+++ b/doc/TODO
@@ -18,11 +18,11 @@
 + header menu
 + footer menu
 + disallow direct to PHP files
++ common_local_url()
 - require valid nicknames
 - store canonical username for comparison and fetch
 - use only canonical usernames
 - use only canonical email addresses
-- common_local_url()
 - configuration system ($config)
 - RSS 1.0 feeds of a user's notices
 - RSS 1.0 dump of a user's notices
@@ -33,7 +33,14 @@
 - license on shownotice
 - design from Open Source Web Designs
 - TOS checkbox on register
+- pretty URLs
 - release 0.1
+- content negotiation for interface language
+- content negotiation for content type
+- content negotiation for encoding
+- content negotiation for charset
+- If-Modified-Since support
+- Vary
 - delete a notice
 - gettext
 - subscribe remote
diff --git a/lib/common.php b/lib/common.php
index b4c2f9b6e7..2625d08ef4 100644
--- a/lib/common.php
+++ b/lib/common.php
@@ -17,6 +17,9 @@
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
+/* XXX: break up into separate modules (HTTP, HTML, user, files) */
+
+
 if (!defined('LACONICA')) { exit(1) }
 
 define('AVATAR_PROFILE_SIZE', 96);
@@ -254,6 +257,16 @@ function common_avatar_url($filename) {
 	return $config['avatar']['path'] . '/' . $filename;
 }
 
+function common_local_url($action, $args) {
+	/* XXX: pretty URLs */
+	$extra = '';
+	foreach ($args as $key => $value) {
+		$extra .= "&${key}=${value}";
+	}
+	/* XXX: correct path */
+	return "/index.php?action=${action}${extra}";
+}
+
 // XXX: set up gettext
 
 function _t($str) { $str }