From 9bed97a36c62fed7b3f44f0cf8870dd31a55e378 Mon Sep 17 00:00:00 2001 From: Evan Prodromou Date: Thu, 15 Jan 2009 21:19:23 +0000 Subject: [PATCH 1/2] Move ID param to end of menuItem and fix bad 'wrap' element --- lib/action.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/action.php b/lib/action.php index 4a164d8b01..a8b5e70b13 100644 --- a/lib/action.php +++ b/lib/action.php @@ -194,11 +194,11 @@ class Action extends HTMLOutputter // lawsuit function showBody() { $this->elementStart('body'); - $this->elementStart('wrap'); + $this->elementStart('div', 'wrap'); $this->showHeader(); $this->showCore(); $this->showFooter(); - $this->elementEnd('wrap'); + $this->elementEnd('div', 'wrap'); $this->elementEnd('body'); } @@ -576,7 +576,7 @@ class Action extends HTMLOutputter // lawsuit // Added @id to li for some control. // XXX: We might want to move this to htmloutputter.php - function menuItem($url, $text, $id=null, $title=null, $is_selected=false) + function menuItem($url, $text, $title=null, $is_selected=false, $id=null) { $lattrs = array(); if ($is_selected) { From c52d49f2fab9f08714ac6c3f950f23ee8497412f Mon Sep 17 00:00:00 2001 From: Evan Prodromou Date: Thu, 15 Jan 2009 21:19:44 +0000 Subject: [PATCH 2/2] Fix some formatting in list items --- lib/noticelist.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/noticelist.php b/lib/noticelist.php index 0fc6d513f4..ad3af43914 100644 --- a/lib/noticelist.php +++ b/lib/noticelist.php @@ -342,7 +342,7 @@ class NoticeListItem extends Widget $this->out->elementStart('dl', 'timestamp'); $this->out->element('dt', _('Published')); $this->out->elementStart('dd', null); - $this->out->element('a', array('rel' => 'bookmark', + $this->out->elementStart('a', array('rel' => 'bookmark', 'href' => $noticeurl)); $dt = common_date_iso8601($this->notice->created); $this->out->element('abbr', array('class' => 'published',