GNUsocial
/
gnu-social
4
0
Fork 1
Code Issues Releases Wiki Activity

added missing return statement after showForm call 

Issue #3125 at http://status.net/open-source/issues/3125 (and its duplicate 3127) describe buggy behaviour when trying to create a new group - i.e. the group is still created but with nickname NULL.

The reason the group is created is that when failing Nickname::normalize, the function trySave() in actions/newgroup.php doesn't call 'return' - meaning it just keeps going despite the error thrown. It a

So the simple solution to this bug was adding a return call at line 128, inside the catch just after the showForm(...) call.
This commit is contained in:
Mikael Nordfeldth 2012-08-06 22:35:38 +02:00
parent 3ad3535cd8
commit ea837cea67
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
actions/newgroup.php
View File

@ -125,6 +125,7 @@ class NewgroupAction extends Action
$nickname = Nickname::normalize($this->trimmed('newnickname'));
} catch (NicknameException $e) {
$this->showForm($e->getMessage());
return;
}
$fullname = $this->trimmed('fullname');
$homepage = $this->trimmed('homepage');