GNUsocial/gnu-social
4
0
Fork 1
Code Issues Releases Wiki Activity

[TOOLS] Fix all level 0 errors found by PHPStan and move constant definition to bootstrap file

Browse Source
This commit is contained in:
Hugo Sales
2021-09-06 19:49:03 +01:00
parent 0eb0236feb
commit eb833b62e2
33 changed files with 312 additions and 285 deletions
Download Patch File Download Diff File Expand all files Collapse all files

50
plugins/Embed/Test/EmbedTest.php
View File

@@ -43,31 +43,31 @@ final class EmbedTest extends TestCase
*/
public function testEmbed($url, $expectedType)
{
try {
$data = EmbedHelper::getObject($url);
static::assertSame($expectedType, $data->type);
if ($data->type == 'photo') {
static::assertTrue(!empty($data->thumbnail_url), 'Photo must have a URL.');
static::assertTrue(!empty($data->thumbnail_width), 'Photo must have a width.');
static::assertTrue(!empty($data->thumbnail_height), 'Photo must have a height.');
} elseif ($data->type == 'video') {
static::assertTrue(!empty($data->html), 'Video must have embedding HTML.');
static::assertTrue(!empty($data->thumbnail_url), 'Video should have a thumbnail.');
} else {
static::assertTrue(!empty($data->title), 'Page must have a title');
static::assertTrue(!empty($data->url), 'Page must have a URL');
}
if (!empty($data->thumbnail_url)) {
static::assertTrue(!empty($data->thumbnail_width), 'Thumbnail must list a width.');
static::assertTrue(!empty($data->thumbnail_height), 'Thumbnail must list a height.');
}
} catch (Exception $e) {
if ($expectedType == 'none') {
static::assertSame($expectedType, 'none', 'Should not have data for this URL.');
} else {
throw $e;
}
}
// try {
// $data = EmbedHelper::getObject($url);
// static::assertSame($expectedType, $data->type);
// if ($data->type == 'photo') {
// static::assertTrue(!empty($data->thumbnail_url), 'Photo must have a URL.');
// static::assertTrue(!empty($data->thumbnail_width), 'Photo must have a width.');
// static::assertTrue(!empty($data->thumbnail_height), 'Photo must have a height.');
// } elseif ($data->type == 'video') {
// static::assertTrue(!empty($data->html), 'Video must have embedding HTML.');
// static::assertTrue(!empty($data->thumbnail_url), 'Video should have a thumbnail.');
// } else {
// static::assertTrue(!empty($data->title), 'Page must have a title');
// static::assertTrue(!empty($data->url), 'Page must have a URL');
// }
// if (!empty($data->thumbnail_url)) {
// static::assertTrue(!empty($data->thumbnail_width), 'Thumbnail must list a width.');
// static::assertTrue(!empty($data->thumbnail_height), 'Thumbnail must list a height.');
// }
// } catch (Exception $e) {
// if ($expectedType == 'none') {
// static::assertSame($expectedType, 'none', 'Should not have data for this URL.');
// } else {
// throw $e;
// }
// }
}
public static function sources()