Use exception instead of if-statement in File::saveNew
This commit is contained in:
parent
02418cffd8
commit
edb73ec480
@ -82,14 +82,15 @@ class File extends Managed_DataObject
|
|||||||
* @param string $given_url
|
* @param string $given_url
|
||||||
* @return File
|
* @return File
|
||||||
*/
|
*/
|
||||||
public static function saveNew(array $redir_data, $given_url) {
|
public static function saveNew(array $redir_data, $given_url)
|
||||||
|
{
|
||||||
|
$file = null;
|
||||||
|
|
||||||
// I don't know why we have to keep doing this but I'm adding this last check to avoid
|
try {
|
||||||
// uniqueness bugs.
|
// I don't know why we have to keep doing this but we run a last check to avoid
|
||||||
|
// uniqueness bugs.
|
||||||
$file = File::getKV('urlhash', self::hashurl($given_url));
|
$file = File::getByUrl($given_url);
|
||||||
|
} catch (NoResultException $e) {
|
||||||
if (!$file instanceof File) {
|
|
||||||
$file = new File;
|
$file = new File;
|
||||||
$file->urlhash = self::hashurl($given_url);
|
$file->urlhash = self::hashurl($given_url);
|
||||||
$file->url = $given_url;
|
$file->url = $given_url;
|
||||||
|
Loading…
Reference in New Issue
Block a user