GNUsocial/gnu-social
4
0
Fork 1
Code Issues Releases Wiki Activity

[COMPONENT][Posting] DB::Flush after Notification and fix minor issues with In targets

Browse Source
This commit is contained in:
Diogo Peralta Cordeiro
2022-01-04 22:04:23 +00:00
parent 9df9c6a19c
commit ee007befa4
3 changed files with 64 additions and 62 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
components/Notification/Notification.php
View File

@@ -89,11 +89,14 @@ class Notification extends Component
}
if (Event::handle('NewNotificationShould', [$activity, $target]) === Event::next) {
// TODO: use https://symfony.com/doc/current/notifier.html
DB::persist(Entity\Notification::create([
// XXX: Unideal as in failures the rollback will leave behind a false notification,
// but most notifications (all) require flushing the objects first
// Should be okay as long as implementors bear this in mind
DB::wrapInTransaction(fn() => DB::persist(Entity\Notification::create([
'activity_id' => $activity->getId(),
'target_id' => $target->getId(),
'reason' => $reason,
]));
])));
}
} else {
// We have no authority nor responsibility of notifying remote actors of a remote actor's doing