GNUsocial/gnu-social
4
0
Fork 1
Code Issues Releases Wiki Activity

updateWithKeys now understands multi-column keys

Browse Source 
and automatically identifies _which_ columns are the right ones,
so for example 'uri' primary keys don't need to be explicitly set
This commit is contained in:
Mikael Nordfeldth
2016-01-28 16:42:59 +01:00
parent d94f9031ff
commit efe23ed404
5 changed files with 24 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
classes/Managed_DataObject.php
View File

@@ -420,12 +420,16 @@ abstract class Managed_DataObject extends Memcached_DataObject
* @param DB_DataObject &$orig Must be "instanceof" $this
* @param string $pid Primary ID column (no escaping is done on column name!)
*/
public function updateWithKeys(Managed_DataObject $orig, $pid='id')
public function updateWithKeys(Managed_DataObject $orig, $pid=null)
{
if (!$orig instanceof $this) {
throw new ServerException('Tried updating a DataObject with a different class than itself.');
}
if ($this->N <1) {
throw new ServerException('DataObject must be the result of a query (N>=1) before updateWithKeys()');
}
// do it in a transaction
$this->query('BEGIN');
@@ -452,11 +456,23 @@ abstract class Managed_DataObject extends Memcached_DataObject
return true;
}
$qry = sprintf('UPDATE %1$s SET %2$s WHERE %3$s = %4$s',
if ($pid === null) {
$schema = static::schemaDef();
$pid = $schema['primary key'];
unset($schema);
}
$pidWhere = array();
foreach((array)$pid as $pidCol) {
$pidWhere[] = sprintf('%1$s = %2$s', $pidCol, $this->_quote($orig->$pidCol));
}
if (empty($pidWhere)) {
throw new ServerException('No primary ID column(s) set for updateWithKeys');
}
$qry = sprintf('UPDATE %1$s SET %2$s WHERE %3$s',
common_database_tablename($this->tableName()),
implode(', ', $parts),
$pid,
$this->_quote($orig->$pid));
implode(' AND ', $pidWhere));
$result = $this->query($qry);
if ($result === false) {