GNUsocial/gnu-social
4
0
Fork 1
Code Issues Releases Wiki Activity

Twitter-compatible API: better error handling for replier_by_reply()

Browse Source 
darcs-hash:20080728230221-ca946-68253052cfcd800a6da979e2a615d4847b1b05f3.gz
This commit is contained in:
zach 2008-07-28 19:02:21 -04:00
parent 0f4be67392
commit f318f41ebf
1 changed files with 11 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
lib/twitterapi.php
View File

@ -63,7 +63,7 @@ class TwitterapiAction extends Action {
$twitter_status['in_reply_to_status_id'] = ($notice->reply_to) ? intval($notice->reply_to) : NULL; $twitter_status['in_reply_to_status_id'] = ($notice->reply_to) ? intval($notice->reply_to) : NULL;
$twitter_status['source'] = NULL; # XXX: twitterific, twitterfox, etc. Not supported yet. $twitter_status['source'] = NULL; # XXX: twitterific, twitterfox, etc. Not supported yet.
$twitter_status['id'] = intval($notice->id); $twitter_status['id'] = intval($notice->id);
$twitter_status['in_reply_to_user_id'] = ($notice->reply_to) ? $this->replier_by_reply($notice->reply_to) : NULL; $twitter_status['in_reply_to_user_id'] = ($notice->reply_to) ? $this->replier_by_reply(intval($notice->reply_to)) : NULL;
$twitter_status['favorited'] = NULL; # XXX: Not implemented on Laconica yet. $twitter_status['favorited'] = NULL; # XXX: Not implemented on Laconica yet.
if ($get_user) { if ($get_user) {
@ -206,21 +206,18 @@ class TwitterapiAction extends Action {
} }
function replier_by_reply($reply_id) { function replier_by_reply($reply_id) {
$notice = Notice::staticGet($reply_id); $notice = Notice::staticGet($reply_id);
if ($notice) {
if (!$notice) { $profile = $notice->getProfile();
common_debug("TwitterapiAction::replier_by_reply: Got a bad notice_id: $reply_id"); if ($profile) {
return intval($profile->id);
} else {
common_debug('Can\'t find a profile for notice: ' . $notice->id, __FILE__);
}
} else {
common_debug("Can't get notice: $reply_id", __FILE__);
} }
return NULL;
$profile = $notice->getProfile();
if (!$profile) {
common_debug("TwitterapiAction::replier_by_reply: Got a bad profile_id: $profile_id");
return false;
}
return intval($profile->id);
} }
// XXX: Candidate for a general utility method somewhere? // XXX: Candidate for a general utility method somewhere?