GNUsocial
/
gnu-social
4
0
Fork 1
Code Issues Releases Wiki Activity

- Remove extraneous style stuff from Echo plugin - that stuff should 

be handled via CSS in the theme.
- Updated installation instructions on Echo and Disqus plugins
This commit is contained in:
Zach Copley 2010-08-14 00:07:12 +00:00
parent 20d0723dec
commit fa4b360ba0
2 changed files with 20 additions and 55 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
plugins/DisqusPlugin.php
View File

@ -53,9 +53,12 @@ if (!defined('STATUSNET')) {
* *
* NOTE: the 'div_style' in an optional parameter that passes in some * NOTE: the 'div_style' in an optional parameter that passes in some
* inline CSS when creating the Disqus widget. It's a shortcut to make * inline CSS when creating the Disqus widget. It's a shortcut to make
* the widget look OK with the the default StatusNet theme. If you leave * the widget look OK with the default StatusNet theme. If you leave
* it out you'll have to edit your theme CSS files to make the widget * it out you'll have to edit your theme CSS files to make the widget
* look good. * look good. You can also control the way the widget looks by
* adding style rules to your theme.
*
* See: http://help.disqus.com/entries/100878-css-customization
* *
* @category Plugin * @category Plugin
* @package StatusNet * @package StatusNet

68
plugins/EchoPlugin.php
View File

@ -36,54 +36,26 @@ if (!defined('STATUSNET')) {
* *
* This plugin adds an Echo commenting widget to each notice page on * This plugin adds an Echo commenting widget to each notice page on
* your site. To get it to work, first you'll have to sign up for Echo * your site. To get it to work, first you'll have to sign up for Echo
* (a commercial service) and register your site's URL. * (a for-pay service) and register your site's URL.
* *
* http://aboutecho.com/ * http://aboutecho.com/
* *
* Once you've done that it's pretty straight forward to turn the * Once you've done that it's pretty straight forward to turn the
* plugin on, just add: * plugin on; just add this to your config.php:
* *
* addPlugin('Echo'); * addPlugin(
* 'Echo',
* array('div_style' => 'width:675px; padding-top:10px; position:relative; float:left;')
* );
* *
* to your config.php. The defaults should work OK with the default * NOTE: the 'div_style' in an optional parameter that passes in some
* theme, but there are a lot of options to customize the look and * inline CSS when creating the Echo widget. It's a shortcut to make
* feel of the comment widget. You can control both the CSS for the * the widget look OK with the default StatusNet theme. If you leave
* div that contains the widget, as well as the CSS for the widget * it out you'll have to edit your theme CSS files to make the widget
* itself via config parameters that can be passed into the plugin. * look good. You can also control the way the widget looks by
* See below for a more complex example: * adding style rules to your theme.
* *
* // Custom stylesheet for Echo commenting widget * See: http://wiki.js-kit.com/Skinning-Guide#UsingCSSnbsptocustomizefontsandcolors
* // See: http://wiki.js-kit.com/Skinning-Guide#UsingCSSnbsptocustomizefontsandcolors
* $stylesheet = <<<ENDOFCSS
* .js-CommentsArea { width: 400px; }
* .jsk-HeaderWrapper { display: none; }
* .jsk-ItemUserAvatar { display: none; }
* .jsk-ItemBody { margin-left: -48px; }
* .js-kit-avatars-wrapper { display: none; }
* .js-kit-nonLoggedUserInfo { margin-left: -75px; }
* .js-singleViaLinkWrapper { display: none; }
* .js-CommentsSkin-echo div.jsk-ThreadWrapper { padding: 0px; }
* .js-singleCommentAdminStar { display: none !important; }
* .js-singleCommentName { margin-right: 1em; }
* .js-kit-miniProfile { background-color:#FFFFFF; }
* .jskit-MenuContainer { background-color:#FFFFFF; }
* .jskit-MenuItemMO { background-color: #EDEDED; }
* .jsk-CommentFormButton { display: none; }
* .js-singleCommentReplyable { display: none; }
* .jsk-CommentFormSurface { display: none; }
* .js-kit-tab-follow { display: none; }
* ENDOFCSS;
*
* addPlugin(
* 'Echo',
* array
* (
* // div_css is the css for the div containing the comment widget
* 'div_css' => 'width:675px; padding-top:10px; position:relative; float:left;',
* // stylesheet is the CSS for the comment widget itself
* 'stylesheet' => $stylesheet
* )
* );
* *
* @category Plugin * @category Plugin
* @package StatusNet * @package StatusNet
@ -122,24 +94,14 @@ class EchoPlugin extends Plugin
// NOTE: there are some other attributes that could be useful // NOTE: there are some other attributes that could be useful
// http://wiki.js-kit.com/Echo-Behavior // http://wiki.js-kit.com/Echo-Behavior
if (empty($this->div_css)) { if (!empty($this->div_style)) {
// This CSS seems to work OK with the default theme $attrs['style'] = $this->div_style;
$attrs['style'] = 'width:675px; padding-top:10px; position:relative; float:left;';
} else {
$attrs['style'] = $this->css;
} }
$action->element('div', $attrs, null); $action->element('div', $attrs, null);
} }
} }
function onEndShowStyles($action)
{
if (get_class($action) == 'ShownoticeAction' && !empty($this->stylesheet)) {
$action->style($this->stylesheet);
}
}
function onPluginVersion(&$versions) function onPluginVersion(&$versions)
{ {
$versions[] = array('name' => 'Echo', $versions[] = array('name' => 'Echo',