pluginified most of hasFave, getFaves and related calls

The code is now more event-driven when it comes to rendering notices and their related HTML elements, since we can't have direct calls from core to a plugin. lib/activitymover.php has a function to move a Favorite activity which will not happen now. The move must be pluginified and performed as an event which plugins can catch on to.
2014-06-27 13:58:35 +02:00
parent 29730b6ca7
commit fcdd061b4f
29 changed files with 580 additions and 421 deletions
--- a/plugins/Favorite/lib/favcommand.php
+++ b/plugins/Favorite/lib/favcommand.php
@@ -0,0 +1,52 @@
+<?php
+
+class FavCommand extends Command 
+{ 
+    var $other = null; 
+ 
+    function __construct($user, $other) 
+    { 
+        parent::__construct($user); 
+        $this->other = $other; 
+    } 
+ 
+    function handle($channel) 
+    { 
+        $notice = $this->getNotice($this->other); 
+ 
+        $fave            = new Fave(); 
+        $fave->user_id   = $this->user->id; 
+        $fave->notice_id = $notice->id; 
+        $fave->find(); 
+ 
+        if ($fave->fetch()) { 
+            // TRANS: Error message text shown when a favorite could not be set because it has already been favorited. 
+            $channel->error($this->user, _('Could not create favorite: Already favorited.')); 
+            return; 
+        } 
+ 
+        $fave = Fave::addNew($this->user->getProfile(), $notice); 
+ 
+        if (!$fave) { 
+            // TRANS: Error message text shown when a favorite could not be set. 
+            $channel->error($this->user, _('Could not create favorite.')); 
+            return; 
+        } 
+ 
+        // @fixme favorite notification should be triggered 
+        // at a lower level 
+ 
+        $other = User::getKV('id', $notice->profile_id); 
+ 
+        if ($other && $other->id != $this->user->id) { 
+            if ($other->email && $other->emailnotifyfav) { 
+                mail_notify_fave($other, $this->user, $notice); 
+            } 
+        } 
+ 
+        $this->user->blowFavesCache(); 
+ 
+        // TRANS: Text shown when a notice has been marked as favourite successfully. 
+        $channel->output($this->user, _('Notice marked as fave.')); 
+    } 
+}