0a20abf1d8
Email notify-on-fave moved to Profile_prefs (run upgrade.php)
2014-07-13 19:46:40 +02:00
933bf0b026
Start and End EmailSaveForm events now take a scoped profile
2014-07-13 15:42:15 +02:00
c8873de08b
Start and End EmailFormData events include current profile
2014-07-13 15:33:44 +02:00
a9bfa1979d
Don't send favorite notifications unless the user wants it.
2014-07-13 12:58:52 +02:00
6f593a79d4
making more sense in mail_notify_fav
...
We should probably get rid of this function, at least storing everything in
lib/mail.php - but until then, at least let's make it more understandable.
2014-07-13 12:56:43 +02:00
0e8148af86
When modplus.css got moved, it should've re-related an image path
2014-07-07 01:40:33 +02:00
2eea7a2d4b
Do proper Activity-plugin based mention notification
2014-07-07 01:15:43 +02:00
aadc7398dc
ModPlus and some layouting issues regarding fixes
2014-07-06 01:37:31 +02:00
fffacaa27c
FavorAction now uses Notice::saveActivity
2014-07-06 01:37:03 +02:00
aa33b7f21c
Fave does not carry a type
...
it did in FreeSocial, where I copied my code from.
2014-07-05 16:28:09 +02:00
57a2d7a0e2
Bad ActivityObject generation of Fave
2014-07-05 00:15:22 +02:00
ffb9d7ad3f
Rewriting code for notice representation
...
Getting rid of NoticeListItemAdapter, putting more into ActivityHandlerPlugin
and relying on plugins to handle rendering code of the content. This gives us
a lot more structure and consistency in notice structure and allows activity
plugins to stop rendering certain kinds of notices more easily.
There should also be a property for an ActivityHandlerPlugin class to avoid
rendering notices in the ordinary stream, so we don't have to overload stuff.
2014-07-04 14:14:49 +02:00
eda69cabaf
Remove Ostatus_profile when releted Profile is deleted
2014-07-04 11:45:42 +02:00
4b40d6bb2a
TagprofileAction fiddled with, now doesn't require OStatus override
...
But it still doesn't quite work properly, so a lot of work is necessary for this.
2014-07-03 14:02:21 +02:00
b63f6e949c
Converted all ActivityObject::fromProfile to $profile->asActivityObject
2014-07-03 10:51:36 +02:00
c44146d6f8
Favorites are now being stored from activities
2014-07-02 18:38:19 +02:00
2e6a32c7be
Most of the activityobject-saving for Favorite implemented
2014-07-02 11:38:55 +02:00
b66ec247db
Caching fixes for Fave class
2014-07-02 11:38:51 +02:00
9f4bcbad8a
checkAuthorship events, Ostatus_profile rewrite to handle it
...
Lost dependency of OStatus plugin for lib/microappplugin.php, whoo!
also noting which plugins should be upgraded to new saveActivity support.
Favorite plugin won't work with the new system just yet, it doesn't have
the necessary functions to extract activity objects, but that's coming
in the next (few) commits.
2014-07-02 11:38:45 +02:00
acb07ef52f
Added saveActivity method to Notice class
...
saveActivity will accept an Activity which gets parsed and saved through
plugins. So when an ActivityHandlerPlugin (such as Favorite will be soon)
gets a feed to save, this will be the function called instead of saveNew.
2014-07-02 11:38:37 +02:00
687f8ab42c
GET, HEAD, DELETE are strings not constants
2014-07-02 11:38:27 +02:00
38bea34562
Moved functions into ActivityHandlerPlugin from MicroAppPlugin
...
Dummy functions in Favorite plugin so far
2014-07-02 11:37:46 +02:00
d0da552722
SalmonAction and extensions simplified
2014-06-28 20:33:09 +02:00
138d26d488
Favorite "aside"-sections moved, also small fixes left from before
...
Action now has 'isAction' which compares the loaded Action with names
of classes in an array (added without the 'Action') to its own type.
2014-06-28 16:09:46 +02:00
7e597ea7cc
More Favorite pluginification (favecount, cache, menus(favecount, cache, menus))
2014-06-28 14:03:30 +02:00
c137ead909
Confusing documentation and tooltip texts in Bookmark
2014-06-28 13:02:52 +02:00
fcdd061b4f
pluginified most of hasFave, getFaves and related calls
...
The code is now more event-driven when it comes to rendering notices
and their related HTML elements, since we can't have direct calls from
core to a plugin.
lib/activitymover.php has a function to move a Favorite activity which
will not happen now. The move must be pluginified and performed as an
event which plugins can catch on to.
2014-06-27 14:09:02 +02:00
c4037a7549
Moved Favorite EVENTS into plugin folder text file
2014-06-24 16:47:44 +02:00
db7cc7fa75
Favorite functionality put into plugin (not done yet)
...
Now we have to fix any code in the core which directly uses the Fave class
or any other favorite stuff, since it is pluginised and thus might not be
available on some installations.
2014-06-24 15:58:53 +02:00
c74dc15173
DiscoveryHints gets microformats2 parsing abilities
2014-06-24 01:27:03 +02:00
55418685c4
DiscoveryHints now properly returns hcard url
2014-06-23 20:51:37 +02:00
41a233f106
ModPlus available also for non-logged in users.
2014-06-23 20:30:00 +02:00
725af5edd0
Event listing boolean logic error
2014-06-23 20:22:15 +02:00
4f59abea9a
don't show ModPlus for group profiles
2014-06-23 19:08:15 +02:00
abcbca5a94
Group listing in Directory plugin works again
2014-06-23 19:02:47 +02:00
faa12e63c0
No nickname in profile listing
2014-06-23 18:59:32 +02:00
af02f445e4
Event cache clearing bug
2014-06-23 14:23:44 +02:00
703443f152
Event upgraded to microformats2
2014-06-23 14:20:06 +02:00
658c6ab9a8
RSVP stricter typing
2014-06-23 14:16:34 +02:00
42104612bd
Make sure the Attention::saveNew does not cause an exception so queue items get removed
...
It's less of a problem that one queue-item does not get handled, attention wise,
than that the queue keeps filling up. The typical error raised here is 'already exists'
so it's not even the case that the item won't get handled (it already has been).
The real problem is that the queue_item table accepts duplicates (content-wise) which it
should not.
2014-06-22 17:22:04 +02:00
414a95a784
Initial move towards microformats2
...
No validation has been attempted yet. Lots of changes left. This
is visibly not (very) different from the previous CSS layout. But
some simplifications have been made.
Might cause issues with local changes to themes and CSS. Also maybe
javascript which depends on certain legacy microformats elements.
The move to microformats2 is motivated by the announcement that all
microformats should be migrated to version 2, as of 2014-06-20 at:
http://microformats.org/2014/06/20/microformats-org-turns-9-upgrade-to-microformats2
2014-06-22 17:11:04 +02:00
e4f1c77d6b
showAvatar functions deduplicated into Widget class
2014-06-21 23:25:50 +02:00
de53e74f40
Proper HTTP status codes for WebFinger search miss
2014-06-04 12:59:58 +02:00
6d0ac21185
Return 404 on resource-not-found for WebFinger
2014-06-04 12:46:06 +02:00
d350a20e1f
Less verbose debugging (also don't log private keys)
...
Magicsig private keys were logged. That's probably not a good thing.
MagicEnvelope full XML entries no longer spam the log either.
2014-06-03 12:53:04 +02:00
aaef11077d
Default of Magicsig keypair toString should be secure
...
Prevent crappy coders from leaking private keys.
2014-06-03 12:51:52 +02:00
c99d4eddb1
Moved Poll CSS into the plugin directory
2014-06-03 11:38:40 +02:00
9a19588ac9
Moved QnA CSS into the plugin directory
2014-06-03 11:36:32 +02:00
e6dcb0c40e
Moved Event CSS into the plugin directory
2014-06-03 11:34:39 +02:00
a7531ca5c7
Moved Bookmark CSS into the plugin directory
2014-06-03 03:08:14 +02:00
0bc122ff58
Magicsig::generate is now static
...
This also fixes a problem with "initial salmon slap", which was a
problem for newly registered accounts which would have their first
salmon slap fail to distribute since there was a problem with Magicsig
keys. Apparently we have to re-read them with importKeys so the
Crypt_RSA objects publicKey and privateKey match later instances of them.
I think it may have been that generate() doesn't specify a signatureMode,
but I leave experimentation of that to the future.
2014-06-02 21:50:40 +02:00
537dff7987
Salmon posts can only be made for local users. More typing!
...
Since we of course don't have the remote party's private keys anyway.
I made some small fixes in Magicsig class too, removing unnecessary code.
2014-06-02 19:46:42 +02:00
2cd25039af
Quick-return is more comprehensible than long if statements
2014-06-02 19:37:06 +02:00
f7479e3f57
Prepare for WebFinger magicsig data for remote profiles
2014-06-02 19:33:09 +02:00
78805d113a
MagicEnvelope discoverKeyPair now returns string
...
getKeyPair fills in missing data so it's a complete Magicsig.
We may use insert() here in the future so the Magicsig is cached locally.
2014-06-02 18:31:48 +02:00
d44588f98b
Only use a Profile in MagicEnvelope keypair retrieval
...
So we _know_ there is a profile for the submitter we're about to verify.
2014-06-02 16:12:26 +02:00
56194b3cd9
Magicsig importKeys finetuning and getHash() use
2014-06-02 16:11:15 +02:00
dc52a8ff43
Don't ensureProfile before we verify signature
2014-06-02 16:10:26 +02:00
00b2bddc7c
Clarify it's not base64, but base64url, encoding in Magicsig
2014-06-02 14:51:15 +02:00
993ad00333
Improve debugging for Salmon slaps
2014-06-02 14:20:58 +02:00
d534ea7bd6
Try the whole Salmon action for AlreadyFulfilledException
...
If we have already fulfilled the action, we don't have to send an error back.
2014-06-02 13:57:30 +02:00
c1dc13bef0
Magicsig warning message would fail to get bits
2014-06-02 13:35:29 +02:00
db443e9374
File::processNew now static and always throws exception on failure
2014-06-02 02:11:23 +02:00
d6f52f5939
File::processNew can return -1 which was not true for empty()
...
Also, File->getEnclosure() now throws exception if not enough metadata.
2014-06-02 01:46:09 +02:00
d596513e39
Stronger typing for NoticeListItem and so
2014-06-02 00:20:27 +02:00
3ef8322b03
There could be unresolvable FeedSub entries
2014-06-01 16:07:08 +02:00
75711ae06a
Magicsig is made a bit less cumbersome
2014-05-31 13:41:49 +02:00
411f3b86a4
Use locally cached Salmon keys for profiles
...
Please note that we're not yet actually caching them ourselves.
2014-05-31 12:51:51 +02:00
0c2134f9ad
Last objectification of MagicEnvelope. Smarter SalmonAction
2014-05-31 12:00:46 +02:00
120e5c685a
Template engine is a good idea, but not in that implementation
2014-05-31 00:37:58 +02:00
62e8081863
Maybe the least necessary plugin: PoweredByStatusNet
2014-05-31 00:04:02 +02:00
9e6599b9fb
Salmon log message tidying up
2014-05-28 14:07:47 +02:00
03fc02c26f
Bad variable names (fixes last commit)
2014-05-27 13:02:26 +02:00
41773d3f67
MagicEnvelope object orientation (no passing arrays)
...
MagicEnvelope now uses object properties instead of passing arrays
around everywhere.
2014-05-27 12:01:12 +02:00
14251d26ad
Make MagicEnvelope self-reference
...
Also, a stricer typing for DOMDocument in fromDom parsing function.
2014-05-27 10:18:36 +02:00
54ae0ed3cc
Removed MagicEnvelopeCompat, legacy from SN <0.9.7
2014-05-26 23:54:22 +02:00
7c7426b473
Minor changes in Salmon lib for Magicsig retrieval.
2014-05-26 20:06:45 +02:00
49fa34e234
Make Profile::fromUri use UnknownUriException
2014-05-26 15:05:14 +02:00
ba10da27da
Should not normalize Salmon author URIs.
...
It's normalized in Discovery->lookup later anyway.
2014-05-26 14:20:42 +02:00
8c348c96e7
getAuthorUri is a more appropriate function name
2014-05-26 14:14:54 +02:00
fac102a50a
checkAuthor not used anywhere
2014-05-26 14:13:35 +02:00
3c322abafc
There's no guarantee we have an Ostatus_profile for Feedsub
2014-05-19 18:34:44 +02:00
0dad11bb85
Inform and make use of NoProfileException in OStatus actions
...
This is because Ostatus_profile->localProfile() throws NoProfileException
instead of returning null for profiles which don't exist in Profile table.
2014-05-19 18:07:57 +02:00
63c20e59aa
UsersalmonAction cleanup
2014-05-19 18:07:14 +02:00
228dc1f851
Ostatus_profile throws NoProfileException from localProfile()
...
Some implementations of the exception handling is included here,
the actions come in a later commit.
2014-05-19 17:59:36 +02:00
d2c749c7de
NoUriException added and implemented in FeedSub class
...
This is a specific exception for objects which require URI but lack it,
first implemented in FeedSub to allow for identification of bad entries.
2014-05-19 17:30:04 +02:00
fc942f5a04
Removing unused functions from Bookmark plugin
2014-05-19 15:19:17 +02:00
fb82c75b49
adminUpdates setting not available now
...
We don't run a service similar to update.status.net yet. Maybe we should,
but that's for the future to decide. Currently I view it as a callback
that we want to avoid.
2014-05-19 14:53:52 +02:00
1207f4f06f
isLocal() for User_group
2014-05-19 14:46:54 +02:00
f37fc4247a
sprintf for SQL calls, please
2014-05-19 01:09:21 +02:00
d7c40e77b2
Show more links work with AJAX-retrieved HTML
...
Attachment_ajaxAction has been removed since AttachmentAction handles
AJAX calls splendidly.
2014-05-19 00:56:21 +02:00
c93a5252c1
Don't show or preview text/html attachments
...
htmLawed cleans stuff out properly, but there's no very good way right
now to show text/html attachments, since everything gets jumbled up with
our own CSS etc. Best would be an iframe or just a new tab or so.
2014-05-18 23:11:49 +02:00
b0cc9292b1
Notice->repeat() function takes Profile as argument now
2014-05-18 21:03:10 +02:00
c6ba545697
XrdAction extends ManagedAction
2014-05-17 15:14:34 +02:00
cd3cff451f
ConversationTree is now a plugin (not oldschool setting)
...
Conversation trees works pretty bad with the current layout, javascript
etc. So it's best if we separate it and work on it as a side-project. The
oldschool settings are currently being deprecated (or broken out like this).
I'll wait with removing User preferences for oldschool conversation tree,
since that might be reusable data. But I guess it will go in the near future.
2014-05-12 11:51:11 +02:00
d59b39275b
Not sure how much time to spend on GNUsocialPhotos plugin
2014-05-12 11:13:13 +02:00
04b7194511
Notice->getUrl() for shares would throw exception in some feeds
2014-05-10 13:06:18 +02:00
888ac77906
"Twitter card" support had badly referenced HTML outputter
2014-05-10 02:01:58 +02:00
7977361193
Too many bird wings ({), sorry Erkan :)
2014-05-07 09:52:50 +02:00
b59beb50e6
misplaced dollar sign, also URLs != attention URIs
2014-05-07 09:20:57 +02:00
4520e8c517
Old examples of lacking 'new' before 'Exception'
2014-05-07 00:06:16 +02:00
c01138c16b
Forgot 'new' before the Exception class
2014-05-07 00:06:04 +02:00
d1755e4363
Bad variable reference in OembedPlugin
2014-05-06 23:43:02 +02:00
1776c90cb9
Moved oEmbed stuff out to a plugin (Oembed).
2014-05-06 23:32:13 +02:00
074b2b621c
Garbage collection script didn't loop through anything
2014-05-06 16:18:47 +02:00
8b12e41351
User object didn't have getNickname() function
...
We're just jumping on to the Profile->getNickname() function.
2014-05-06 16:08:36 +02:00
869ca2d20b
Missed a $user->id to $profile->id translation
2014-05-06 15:43:06 +02:00
c279a33feb
More Exceptions for FeedSub doSubscribe and related functions
...
Now also garbageCollect will now throw exceptions of failures of all kinds
and only reply true/false on entirely successful runs of sub/unsub.
2014-05-06 15:40:57 +02:00
0fa00d5106
Type testing instead of just empty() in OStatusPlugin
2014-05-06 14:36:52 +02:00
1a0171ef61
MagicEnvelope class now throws exception on XRD fail
2014-05-06 13:11:29 +02:00
fc3125cf28
More modern coding, stuff related to subscriptions
...
Also trying to use the newly implemented AlreadyFulfilledException
2014-05-05 23:58:05 +02:00
150a1abecb
MSN probably doesn't work, and we don't like it anyway
2014-05-05 23:02:17 +02:00
805958cc23
UsersalmonAction updated to stronger typing standards
2014-05-05 19:38:01 +02:00
595d231d9a
GroupsalmonAction updated to stronger typing standards
2014-05-05 19:25:39 +02:00
cdefeda659
More debugging for Salmon activities
2014-05-05 19:10:44 +02:00
bbada781b7
Stronger typing and function access control in OStatus
2014-05-05 19:06:22 +02:00
2ea5f00666
Success debugging was too much noise
2014-05-05 18:59:44 +02:00
960baae1d1
More debugging in Magicsig class verify method
2014-05-05 17:48:21 +02:00
7440dc2145
Prevent spurious refusals of legitimate notices posted to users via Salmon.
...
Make the logic match the intent described in the comments.
The intent is clearly "accept notices whenever (A or B or C)", but
the logic implemented was more like "not ((not A) or (not B) or (not C))",
which is a basical boolean algebra fail (each of those ORs need to
become ANDs for double-negation to work).
The practical implication was that, for example, writing a reply
to someone else's notice and including an @-reference to _another_
user on another site to bring them into the discussion would
fail to deliver the notice to the new user because their server
would basically say `oh no, you can't message this user
from someone else's thread' because an earlier check for
the `A' or `C' parts of `(A or B or C)' prevents `B' from
being checked.
cf.: <http://status.hackerposse.com/notice/55846 >, which was
refused by the nhcrossing.com server because it didn't know
about <http://sn.jonkman.ca/notice/93724 >, even though it would
have passed the later `notice contains a reference to a local user'
check if not for an exception being prematurely thrown.
The whole idea of reporting `which specific check FAILED'
in an `if ANY SUCCEEDS' analysis is just bogus, so nix all of
the distinct ClientExceptions--a single `ALL FAILED' exception
is the only one that makes sense.
2014-05-05 13:35:38 +02:00
4fd3f43ad2
Autocomplete: don't match non-subscribed group-names.
...
There's no point, since we can't post/link to them anyway.
2014-05-05 13:32:18 +02:00
27ed6b7db0
getConversationUrl introduced for linking to conversations
2014-05-01 15:25:19 +02:00
caeb6e583c
We're not interested in Disqus support.
2014-05-01 02:15:10 +02:00
b77a09fdee
Notice URIs are not necessarily URLs.
...
Let's use getUrl() for URL retrieval. May throw exceptions, but
only if it's a Notice that cannot be linked like that anyway.
2014-04-30 20:44:23 +02:00
1acffa9c7a
wtf is Echo? bah, let's get rid of this crap
2014-04-30 20:35:06 +02:00
7d191f8062
s/bestUrl/getUrl/ for notices and microapp objects
2014-04-29 19:46:58 +02:00
c1d2f2516a
VideoThumbnails failure detection improved.
2014-04-29 19:45:42 +02:00
c8d613b916
Minifying javascripts is evil. Let's not do it.
...
The microformats stuff was unused
2014-04-28 18:57:11 +02:00
b0cae37b0f
Datetime representation aligned for microformats2
...
Read more at http://microformats.org/
Also, tooltip text on time representation for humans has been improved.
Unfortunately no standardised representation (like "RFC850") had 4-digit years.
2014-04-28 18:54:55 +02:00
5fd6053220
Code cleanup and enabling User object's etc. getUri()
2014-04-28 14:08:42 +02:00
030639d02d
EmailAuthentication enabled by default
...
The login field said "Username or email address" already, so...
2014-04-28 12:39:57 +02:00
37ce1f4766
Better fallback on UnsupportedMediaException
2014-04-28 12:12:06 +02:00
d59eb5e184
Dynamically generate thumbnails (see full text)
...
The File object now stores width and height of files that can
supply this kind of information. Formats which we can not read
natively in PHP do not currently benefit from this. However an
event hook will be introduced later.
The CreateFileImageThumbnail event is renamed to:
CreateFileImageThumbnailSource to clarify that the hooks should not
generate their own thumbnails but only the source image. Also it now
accepts File objects, not MediaFile objects.
The thumbnail generation is documented in the source code. For
developers, call 'getThumbnail' on a File object and hope for the best.
Default thumbnail sizes have increased to be more appealing.
2014-04-21 20:46:11 +02:00
86ddf120d7
Better event name (creating thumbnail _source_)
2014-04-21 12:33:41 +02:00
639cf48cc7
OStatus onStartNoticeSourceLink to use exceptions
2014-04-19 22:18:36 +02:00
37e9366e88
We get profiles directly, there's no user object anymore
2014-04-18 22:18:11 +02:00
5ef6ee4bc5
Better plugin description for VideoThumbnails
2014-04-16 22:12:15 +02:00
06d4cecf7f
MediaFile thumbnail event hooks + VideoThumbnails plugin
...
The exception thrown from MediaFile will be caught and simply result in
no thumbnail at all right now. In the future we might use a catch-all
and have a "cannot generate preview"-icon or something.
VideoThumbnails requires php5-ffmpeg and php5-gd.
2014-04-16 21:48:58 +02:00
a2a2105058
HTML5 required attribute for some input forms
2014-04-06 11:27:41 +02:00
220b51d8be
Merge commit 'refs/merge-requests/199' of git://gitorious.org/statusnet/mainline into statusnet-merge-requests/199
2014-03-31 13:09:11 +02:00
cb3d863668
Updated and moved XMPP documentation into plugin.
2014-03-11 00:11:25 +01:00
e9e4190b64
IrcManager does not have serverError, so it must throw ServerException
2014-03-10 00:30:41 +01:00
c00491cd7a
Cosmetic changes to common_redirect, clientError, serverError
...
Since these functions exit (or throw exception) after running, there
is no need to have a 'return' statement or similar afterwards.
2014-03-10 00:25:57 +01:00
acbe94936f
common_redirect and clientError exits, so refactor
...
One Event would never be called, and other stuff were redundant clauses.
2014-03-10 00:24:32 +01:00
8d655bc706
Add support for 'nohub' sub_state in FeedSub
...
(requires upgrade.php run)
2014-03-09 23:03:54 +01:00
779ce40ac3
Add functions to avoid direct variable access
2014-03-09 13:31:05 +01:00
a1b0d5fa7e
FeedSub gets a plugin event handler for sub/unsub
2014-03-09 13:27:28 +01:00
940867e39d
RegisterThrottle didn't save the created time
2014-03-07 21:23:49 +01:00
326ad9376e
Cosmetic changes to RegisterThrottle
2014-03-07 21:03:38 +01:00
4e8697c96e
We don't add to inbox anymore.
2014-03-07 00:05:21 +01:00
c4e1cd1289
Added OpportunisticQM README that has good docs
2014-03-06 14:45:18 +01:00
Mikael Nordfeldth
Marcel van der Boom
Joshua Judson Rosen