Mikael Nordfeldth
7978cd6d59
s/EmptyIdException/EmptyPkeyValueException/
2016-06-25 11:50:59 +02:00
Mikael Nordfeldth
b1de90fe08
Send thr:in-reply-to as well, for clarity...
2016-04-01 23:21:57 +02:00
Mikael Nordfeldth
41b64cb8a3
static function declaration
2016-03-07 20:09:15 +01:00
Mikael Nordfeldth
63c087a255
Consistent behaviour for ScopingNoticeStream $scoped
...
We don't guess the current profile anymore if the value of the profile === -1
Also sets $this->scoped for all ScopingNoticeStream inheritors, which just
like in an Action can be null if we're not scoped in any way (logged in).
2016-03-01 14:51:47 +01:00
Mikael Nordfeldth
f74d2d555c
Working on some RSVP code stuff
2016-01-21 02:10:34 +01:00
Mikael Nordfeldth
cae344b67b
Events are now saved but not displayed properly again
2016-01-18 20:57:44 +01:00
Mikael Nordfeldth
0797ee0871
EmptyIdException doesn't carry ->obj
2016-01-16 21:12:53 +01:00
Mikael Nordfeldth
b596391fcd
Avoid having to check for notices without rendered copies in upgrade.php
...
Always call the Notice->getRendered() function to get a rendered copy.
We could perhaps put some sanitation there too in the future
2016-01-06 15:32:27 +01:00
Mikael Nordfeldth
3471213d1c
processFeed would abort on certain errors where findLocalObject failed
2016-01-05 15:00:07 +01:00
Mikael Nordfeldth
34b25e6afc
Use EmptyIdException in Fave deletion try-catch
2016-01-03 22:57:28 +01:00
Mikael Nordfeldth
bda30a92bc
Fave deletion would fail in some cases with missing profiles or notices
2016-01-03 22:35:49 +01:00
Mikael Nordfeldth
37f2da03e1
newUri might as well be put in Managed_DataObject
2015-10-10 21:31:26 +02:00
Mikael Nordfeldth
0c6fe78a73
Shorthand function for getActor
2015-10-03 00:43:34 +02:00
Mikael Nordfeldth
9ad9b91efb
Call it compareVerbs when comparing verbs
2015-09-10 15:27:40 +02:00
Mikael Nordfeldth
030b570051
non-static method was called statically, now defined static
2015-06-23 13:24:19 +02:00
Mikael Nordfeldth
af67f15cf2
FavoritePlugin is now an "ActivityVerbHandlerPlugin"
2015-03-10 15:39:35 +01:00
Mikael Nordfeldth
8a273eef20
Move AlreadyFulfilled check to Fave::addNew
2015-03-10 11:56:23 +01:00
Mikael Nordfeldth
2f86cd8602
utf8mb4 conversion on database with index adjusts
2015-02-12 18:18:55 +01:00
Mikael Nordfeldth
9827e6ad84
The favorite activity is an activity.
2015-02-03 16:53:51 +01:00
Mikael Nordfeldth
adc4dfc081
Wrong variable name (s/fave/object/)
2015-02-03 16:43:56 +01:00
Mikael Nordfeldth
660e8c6efc
Fave::addNew now calls Notice::saveActivity
...
as a bonus we've fixed several FIXME issues for favorite email notification
and updated parts of the codebase for these activities to a more modern style.
2015-02-03 16:34:11 +01:00
Mikael Nordfeldth
0bcecda177
more activity-like terminology in variable names
2015-02-03 15:12:29 +01:00
Mikael Nordfeldth
1104ea2a0e
Fave insert logging directly in insert()
2015-02-03 14:58:22 +01:00
Mikael Nordfeldth
8749c470ca
ArrayWrapper spookiness, must make sure it's a Notice there...
2015-01-12 12:06:19 +01:00
Mikael Nordfeldth
aca5ff1b23
Found some unreachable code in Favorite
...
The portion after StartAtomPubNewActivity would never be reached since
Favorite handles that activity through ActivityHandlerPlugin nowadays.
So I cleaned it up and followed a couple of paths, making stuff prettier.
2015-01-12 02:23:23 +01:00
Mikael Nordfeldth
78dc376f01
Moved some FAVORITE handling from Activity plugin to Favorite
2014-07-28 10:58:24 +02:00
Mikael Nordfeldth
509f31af0e
Favorite plugin now "extends" Activity on NoticeAsActivity
...
Got this mainly from my patches to FreeSocial. The idea is to migrate
also the Note activity to a plugin and have everything be handled as
events, only filling out the basic "context" stuff in the Notice class.
2014-07-28 10:02:53 +02:00
Mikael Nordfeldth
31d53ede91
Bad variable reference in Fave class
2014-07-14 23:37:28 +02:00
Mikael Nordfeldth
eb955fe629
"Notice posted" message in Ajax title for NewnoticeAction
2014-07-14 17:11:54 +02:00
Mikael Nordfeldth
ac44695c44
Put text content into Favorite activities/activityobjects
2014-07-14 13:25:26 +02:00
Mikael Nordfeldth
2eea7a2d4b
Do proper Activity-plugin based mention notification
2014-07-07 01:15:43 +02:00
Mikael Nordfeldth
fffacaa27c
FavorAction now uses Notice::saveActivity
2014-07-06 01:37:03 +02:00
Mikael Nordfeldth
aa33b7f21c
Fave does not carry a type
...
it did in FreeSocial, where I copied my code from.
2014-07-05 16:28:09 +02:00
Mikael Nordfeldth
57a2d7a0e2
Bad ActivityObject generation of Fave
2014-07-05 00:15:22 +02:00
Mikael Nordfeldth
b63f6e949c
Converted all ActivityObject::fromProfile to $profile->asActivityObject
2014-07-03 10:51:36 +02:00
Mikael Nordfeldth
c44146d6f8
Favorites are now being stored from activities
2014-07-02 18:38:19 +02:00
Mikael Nordfeldth
2e6a32c7be
Most of the activityobject-saving for Favorite implemented
2014-07-02 11:38:55 +02:00
Mikael Nordfeldth
b66ec247db
Caching fixes for Fave class
2014-07-02 11:38:51 +02:00
Mikael Nordfeldth
7e597ea7cc
More Favorite pluginification (favecount, cache, menus(favecount, cache, menus))
2014-06-28 14:03:30 +02:00
Mikael Nordfeldth
fcdd061b4f
pluginified most of hasFave, getFaves and related calls
...
The code is now more event-driven when it comes to rendering notices
and their related HTML elements, since we can't have direct calls from
core to a plugin.
lib/activitymover.php has a function to move a Favorite activity which
will not happen now. The move must be pluginified and performed as an
event which plugins can catch on to.
2014-06-27 14:09:02 +02:00
Mikael Nordfeldth
db7cc7fa75
Favorite functionality put into plugin (not done yet)
...
Now we have to fix any code in the core which directly uses the Fave class
or any other favorite stuff, since it is pluginised and thus might not be
available on some installations.
2014-06-24 15:58:53 +02:00