Commit Graph

4064 Commits

Author SHA1 Message Date
Mikael Nordfeldth 048af5ac73 Can't use empty on a function call 2014-10-25 14:29:27 +02:00
Roland Haeder 3d031951f9 Fixed syntax error. :-(
Signed-off-by: Roland Haeder <roland@mxchange.org>
2014-10-25 14:26:22 +02:00
Roland Haeder db704b5d10 Fixed type-hints + added assert + method getGroup().
Signed-off-by: Roland Haeder <roland@mxchange.org>
2014-10-25 14:26:18 +02:00
Roland Haeder 419c2cd5b3 Some fixes/improvements - added getter getGroup() for https://bugz.foocorp.net/T44 - added type-hints in method signatures
---------------------------------------------------------
WARNING: Some plugins attempt to get a property 'group' from (basicly) a Menu
class which does NOT have such property. This badly needs fixing.
---------------------------------------------------------

Signed-off-by: Roland Haeder <roland@mxchange.org>
2014-10-25 14:25:12 +02:00
Mikael Nordfeldth 57b5e2483d A little bit more debugging. 2014-10-25 14:23:15 +02:00
Hannes Mannerheim 8dba84bd76 i had introduced a bug... userdirectory didn't work when logged out 2014-10-21 02:57:52 +02:00
Hannes Mannerheim 0f87edd9f4 remove dupes when infinitescrolling, and add infinitescroll to user lists and userdirectory also 2014-10-20 16:34:37 +02:00
Hannes Mannerheim 4d4a0491f1 groups/all didn't work, also fixed pagination in directory/users, and a convenient delete-button for admins 2014-10-20 16:24:53 +02:00
Hannes Mannerheim e3bb5e1df9 do favorites from default like in API
not quite sure about this, but the deleted code in this commit created
activity notices that we couldn't turn off in config.
2014-10-20 16:17:40 +02:00
Mikael Nordfeldth d0401b19a5 statusnet/gnu-social merge request 22 2014-10-10 20:52:09 +02:00
Aqeel Zafar a7ffc9e14e Fix T46 Blog Plugin is broken
Adds newFormAction() in Blog Plugin to redirect to correct action.
2014-09-29 18:06:54 +05:00
Mikael Nordfeldth 78781050b3 Mats Sjöberg's merge request no.5 from Gitorious 2014-09-25 08:41:25 +02:00
Mikael Nordfeldth ee41bc560c Updated LDAP2 extlib to latest version. 2014-09-25 08:34:55 +02:00
Mikael Nordfeldth a6545d09b8 Added a return true statement for an event handler 2014-09-25 08:32:10 +02:00
Silke Meyer 731d619c1e "return parent" breaks ldap plugin, there's no parent 2014-09-17 17:15:32 +02:00
Mikael Nordfeldth 7e47026085 QnA layout fix, still no answer-action
There is required to be an answer-action element for the threaded view
so we can fetch that action value to an AJAX call which fetches the form.

That is: Currently the "Your answer..." placeholder will fetch a blank URL.
2014-08-24 13:34:01 +02:00
Mikael Nordfeldth f851d3dbf9 tabs to spaces 2014-08-24 13:33:52 +02:00
Roland Haeder e1eadbcf4f Fixes for making Meteor working with HTTPS.
Signed-off-by: Roland Haeder <roland@mxchange.org>
2014-08-24 13:24:42 +02:00
Roland Haeder c1a0132cab Added missing index declarations.
Signed-off-by: Roland Haeder <roland@mxchange.org>
2014-08-24 13:21:59 +02:00
Roland Haeder 3ec64116a4 This JavaScript file is located in js/ - Fixed paths for all targets.
Signed-off-by: Roland Haeder <roland@mxchange.org>
2014-08-24 13:10:19 +02:00
Mikael Nordfeldth 63b61ea2d1 QnA fixes from chimo 2014-08-24 13:05:49 +02:00
Mikael Nordfeldth 3cdc313429 Poll fixes by chimo 2014-08-24 13:01:13 +02:00
Mats Sjöberg 376e63db77 TwitterBridge should not try to send replies to tweets back to Twitter if user hasn't selected to import tweets. 2014-08-21 21:04:06 +03:00
chimo 3edc200b26 PollListItem: Use showNotice args 2014-08-17 13:39:19 -04:00
chimo 0a95cdfa88 Added adaptNoticeListItem and QnAListItem 2014-08-17 13:37:43 -04:00
chimo 850d687901 Added adaptNoticeListItem and PollListItem 2014-08-17 13:33:07 -04:00
Mikael Nordfeldth 9933c00c4f TwitterBridge PHP require_once paths now relative 2014-08-06 09:29:47 +02:00
Mikael Nordfeldth a9676f5b2b RSVP fromNotice now throws NoResultException 2014-08-06 09:23:42 +02:00
Mikael Nordfeldth 9018fd75c6 JOINs and FOLLOWs would have null titles in Activity representation of notices 2014-07-30 00:21:00 +02:00
Mikael Nordfeldth 8674b51144 Activity plugin fix (LeaveListItem unused) 2014-07-29 10:43:58 +02:00
Mikael Nordfeldth 78dc376f01 Moved some FAVORITE handling from Activity plugin to Favorite 2014-07-28 10:58:24 +02:00
Mikael Nordfeldth 509f31af0e Favorite plugin now "extends" Activity on NoticeAsActivity
Got this mainly from my patches to FreeSocial. The idea is to migrate
also the Note activity to a plugin and have everything be handled as
events, only filling out the basic "context" stuff in the Notice class.
2014-07-28 10:02:53 +02:00
Mikael Nordfeldth 6e481d35ed Start/End NoticeAsActivity modifications
More 'scoped' profiles and typing to the functions.
Also, there's no need to send an object as a reference.
2014-07-28 09:40:07 +02:00
Mikael Nordfeldth eb2f93ad2b More use of Profile, less User 2014-07-28 09:34:46 +02:00
Mikael Nordfeldth d11ce2ef3b Consistently use "email-notify_fave" syntax for preference 2014-07-27 23:25:49 +02:00
Mikael Nordfeldth 2d0c7c2c99 ensureWebfinger was never complete in StatusNet. Worked a bit on it. 2014-07-27 23:08:02 +02:00
Mikael Nordfeldth bb1ac66d74 Cronish plugin minor debugging text fixes and so 2014-07-21 09:51:28 +02:00
Mikael Nordfeldth 9a2e3a52c9 Don't access HTTP_USER_AGENT if it doesn't exist 2014-07-15 20:38:58 +02:00
Mikael Nordfeldth ea8cb21e98 Allow exception to be thrown if saveActivityObject fails 2014-07-15 14:12:39 +02:00
Mikael Nordfeldth c96f0aa30f More Activity-based reasoning for saveActivity in Notice
If we can, get the activity ID from the activity itself, instead of the
supplied $options array.
2014-07-14 23:54:58 +02:00
Mikael Nordfeldth 31d53ede91 Bad variable reference in Fave class 2014-07-14 23:37:28 +02:00
Mikael Nordfeldth eb955fe629 "Notice posted" message in Ajax title for NewnoticeAction 2014-07-14 17:11:54 +02:00
Mikael Nordfeldth b0c4a35940 Local favoriting fills out content to saveActivity 2014-07-14 14:05:47 +02:00
Mikael Nordfeldth ae62b91940 Unifying HTML stripping functions to common_strip_html 2014-07-14 13:52:23 +02:00
Mikael Nordfeldth ac44695c44 Put text content into Favorite activities/activityobjects 2014-07-14 13:25:26 +02:00
Mikael Nordfeldth 5ebe01ba36 NoticeStream fixes regarding non-post verbs 2014-07-14 00:59:04 +02:00
Mikael Nordfeldth 0a20abf1d8 Email notify-on-fave moved to Profile_prefs (run upgrade.php) 2014-07-13 19:46:40 +02:00
Mikael Nordfeldth 933bf0b026 Start and End EmailSaveForm events now take a scoped profile 2014-07-13 15:42:15 +02:00
Mikael Nordfeldth c8873de08b Start and End EmailFormData events include current profile 2014-07-13 15:33:44 +02:00
Mikael Nordfeldth a9bfa1979d Don't send favorite notifications unless the user wants it. 2014-07-13 12:58:52 +02:00
Mikael Nordfeldth 6f593a79d4 making more sense in mail_notify_fav
We should probably get rid of this function, at least storing everything in
lib/mail.php - but until then, at least let's make it more understandable.
2014-07-13 12:56:43 +02:00
Mikael Nordfeldth 0e8148af86 When modplus.css got moved, it should've re-related an image path 2014-07-07 01:40:33 +02:00
Mikael Nordfeldth 2eea7a2d4b Do proper Activity-plugin based mention notification 2014-07-07 01:15:43 +02:00
Mikael Nordfeldth aadc7398dc ModPlus and some layouting issues regarding fixes 2014-07-06 01:37:31 +02:00
Mikael Nordfeldth fffacaa27c FavorAction now uses Notice::saveActivity 2014-07-06 01:37:03 +02:00
Mikael Nordfeldth aa33b7f21c Fave does not carry a type
it did in FreeSocial, where I copied my code from.
2014-07-05 16:28:09 +02:00
Mikael Nordfeldth 57a2d7a0e2 Bad ActivityObject generation of Fave 2014-07-05 00:15:22 +02:00
Mikael Nordfeldth ffb9d7ad3f Rewriting code for notice representation
Getting rid of NoticeListItemAdapter, putting more into ActivityHandlerPlugin
and relying on plugins to handle rendering code of the content. This gives us
a lot more structure and consistency in notice structure and allows activity
plugins to stop rendering certain kinds of notices more easily.

There should also be a property for an ActivityHandlerPlugin class to avoid
rendering notices in the ordinary stream, so we don't have to overload stuff.
2014-07-04 14:14:49 +02:00
Mikael Nordfeldth eda69cabaf Remove Ostatus_profile when releted Profile is deleted 2014-07-04 11:45:42 +02:00
Mikael Nordfeldth 4b40d6bb2a TagprofileAction fiddled with, now doesn't require OStatus override
But it still doesn't quite work properly, so a lot of work is necessary for this.
2014-07-03 14:02:21 +02:00
Mikael Nordfeldth b63f6e949c Converted all ActivityObject::fromProfile to $profile->asActivityObject 2014-07-03 10:51:36 +02:00
Mikael Nordfeldth c44146d6f8 Favorites are now being stored from activities 2014-07-02 18:38:19 +02:00
Mikael Nordfeldth 2e6a32c7be Most of the activityobject-saving for Favorite implemented 2014-07-02 11:38:55 +02:00
Mikael Nordfeldth b66ec247db Caching fixes for Fave class 2014-07-02 11:38:51 +02:00
Mikael Nordfeldth 9f4bcbad8a checkAuthorship events, Ostatus_profile rewrite to handle it
Lost dependency of OStatus plugin for lib/microappplugin.php, whoo!

also noting which plugins should be upgraded to new saveActivity support.

Favorite plugin won't work with the new system just yet, it doesn't have
the necessary functions to extract activity objects, but that's coming
in the next (few) commits.
2014-07-02 11:38:45 +02:00
Mikael Nordfeldth acb07ef52f Added saveActivity method to Notice class
saveActivity will accept an Activity which gets parsed and saved through
plugins. So when an ActivityHandlerPlugin (such as Favorite will be soon)
gets a feed to save, this will be the function called instead of saveNew.
2014-07-02 11:38:37 +02:00
Mikael Nordfeldth 687f8ab42c GET, HEAD, DELETE are strings not constants 2014-07-02 11:38:27 +02:00
Mikael Nordfeldth 38bea34562 Moved functions into ActivityHandlerPlugin from MicroAppPlugin
Dummy functions in Favorite plugin so far
2014-07-02 11:37:46 +02:00
Mikael Nordfeldth d0da552722 SalmonAction and extensions simplified 2014-06-28 20:33:09 +02:00
Mikael Nordfeldth 138d26d488 Favorite "aside"-sections moved, also small fixes left from before
Action now has 'isAction' which compares the loaded Action with names
of classes in an array (added without the 'Action') to its own type.
2014-06-28 16:09:46 +02:00
Mikael Nordfeldth 7e597ea7cc More Favorite pluginification (favecount, cache, menus(favecount, cache, menus)) 2014-06-28 14:03:30 +02:00
Mikael Nordfeldth c137ead909 Confusing documentation and tooltip texts in Bookmark 2014-06-28 13:02:52 +02:00
Mikael Nordfeldth fcdd061b4f pluginified most of hasFave, getFaves and related calls
The code is now more event-driven when it comes to rendering notices
and their related HTML elements, since we can't have direct calls from
core to a plugin.

lib/activitymover.php has a function to move a Favorite activity which
will not happen now. The move must be pluginified and performed as an
event which plugins can catch on to.
2014-06-27 14:09:02 +02:00
Mikael Nordfeldth c4037a7549 Moved Favorite EVENTS into plugin folder text file 2014-06-24 16:47:44 +02:00
Mikael Nordfeldth db7cc7fa75 Favorite functionality put into plugin (not done yet)
Now we have to fix any code in the core which directly uses the Fave class
or any other favorite stuff, since it is pluginised and thus might not be
available on some installations.
2014-06-24 15:58:53 +02:00
Mikael Nordfeldth c74dc15173 DiscoveryHints gets microformats2 parsing abilities 2014-06-24 01:27:03 +02:00
Mikael Nordfeldth 55418685c4 DiscoveryHints now properly returns hcard url 2014-06-23 20:51:37 +02:00
Mikael Nordfeldth 41a233f106 ModPlus available also for non-logged in users. 2014-06-23 20:30:00 +02:00
Mikael Nordfeldth 725af5edd0 Event listing boolean logic error 2014-06-23 20:22:15 +02:00
Mikael Nordfeldth 4f59abea9a don't show ModPlus for group profiles 2014-06-23 19:08:15 +02:00
Mikael Nordfeldth abcbca5a94 Group listing in Directory plugin works again 2014-06-23 19:02:47 +02:00
Mikael Nordfeldth faa12e63c0 No nickname in profile listing 2014-06-23 18:59:32 +02:00
Mikael Nordfeldth af02f445e4 Event cache clearing bug 2014-06-23 14:23:44 +02:00
Mikael Nordfeldth 703443f152 Event upgraded to microformats2 2014-06-23 14:20:06 +02:00
Mikael Nordfeldth 658c6ab9a8 RSVP stricter typing 2014-06-23 14:16:34 +02:00
Marcel van der Boom 42104612bd Make sure the Attention::saveNew does not cause an exception so queue items get removed
It's less of a problem that one queue-item does not get handled, attention wise,
than that the queue keeps filling up. The typical error raised here is 'already exists'
so it's not even the case that the item won't get handled (it already has been).

The real problem is that the queue_item table accepts duplicates (content-wise) which it
should not.
2014-06-22 17:22:04 +02:00
Mikael Nordfeldth 414a95a784 Initial move towards microformats2
No validation has been attempted yet. Lots of changes left. This
is visibly not (very) different from the previous CSS layout. But
some simplifications have been made.

Might cause issues with local changes to themes and CSS. Also maybe
javascript which depends on certain legacy microformats elements.

The move to microformats2 is motivated by the announcement that all
microformats should be migrated to version 2, as of 2014-06-20 at:
http://microformats.org/2014/06/20/microformats-org-turns-9-upgrade-to-microformats2
2014-06-22 17:11:04 +02:00
Mikael Nordfeldth e4f1c77d6b showAvatar functions deduplicated into Widget class 2014-06-21 23:25:50 +02:00
Mikael Nordfeldth de53e74f40 Proper HTTP status codes for WebFinger search miss 2014-06-04 12:59:58 +02:00
Mikael Nordfeldth 6d0ac21185 Return 404 on resource-not-found for WebFinger 2014-06-04 12:46:06 +02:00
Mikael Nordfeldth d350a20e1f Less verbose debugging (also don't log private keys)
Magicsig private keys were logged. That's probably not a good thing.
MagicEnvelope full XML entries no longer spam the log either.
2014-06-03 12:53:04 +02:00
Mikael Nordfeldth aaef11077d Default of Magicsig keypair toString should be secure
Prevent crappy coders from leaking private keys.
2014-06-03 12:51:52 +02:00
Mikael Nordfeldth c99d4eddb1 Moved Poll CSS into the plugin directory 2014-06-03 11:38:40 +02:00
Mikael Nordfeldth 9a19588ac9 Moved QnA CSS into the plugin directory 2014-06-03 11:36:32 +02:00
Mikael Nordfeldth e6dcb0c40e Moved Event CSS into the plugin directory 2014-06-03 11:34:39 +02:00
Mikael Nordfeldth a7531ca5c7 Moved Bookmark CSS into the plugin directory 2014-06-03 03:08:14 +02:00
Mikael Nordfeldth 0bc122ff58 Magicsig::generate is now static
This also fixes a problem with "initial salmon slap", which was a
problem for newly registered accounts which would have their first
salmon slap fail to distribute since there was a problem with Magicsig
keys. Apparently we have to re-read them with importKeys so the
Crypt_RSA objects publicKey and privateKey match later instances of them.

I think it may have been that generate() doesn't specify a signatureMode,
but I leave experimentation of that to the future.
2014-06-02 21:50:40 +02:00
Mikael Nordfeldth 537dff7987 Salmon posts can only be made for local users. More typing!
Since we of course don't have the remote party's private keys anyway.

I made some small fixes in Magicsig class too, removing unnecessary code.
2014-06-02 19:46:42 +02:00
Mikael Nordfeldth 2cd25039af Quick-return is more comprehensible than long if statements 2014-06-02 19:37:06 +02:00
Mikael Nordfeldth f7479e3f57 Prepare for WebFinger magicsig data for remote profiles 2014-06-02 19:33:09 +02:00